1642690 - Add identities API and allow setting/getting the signature via identities

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[brice.paccoud]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

In API add preferences managment.
Get a preference
Set a preference

Comment 1

[Mark Banner (:standard8)]

The general intention with WebExtensions is to be more restrictive about what extensions are able to do without permissions from the user.

Being able to fully modify any preference is dangerous, as a WebExtension could for example disable security measures, disable updates or other things.

Another example is that giving access to preferences would automatically grant you account/identity information, which there is an already separate permission for.

I think it would probably be better to approach this request from which preferences you need access to (and maybe why), and then figure out what APIs would be useful around that.

Comment 2

[brice.paccoud]

(In reply to Mark Banner (:standard8) from comment #1)

Hello Mark,

I'm agree with you about security.
My need is to access to signature preference in order to automatically update it from a backend rest api.
I'm going to work on a backend for managing model signature, signature by account, generating signature from model ...
The goal is to deploy automatically signatures without user action.
So today i use expirment API in order to access preference but there is an API existing i want to use it.

Thanks

Comment 3

[Mark Banner (:standard8)]

Thanks, I'm going to make this bug more specific to allow setting/getting the signature on identities - my Conversations add-on could likely use this as well.

We do have the start of identity information for accounts coming in the 78 version, so it could likely be added to that (but not in time for 78):

https://thunderbird-webextensions.readthedocs.io/en/latest/accounts.html

Comment 4

[brice.paccoud]

Hello Mark,

Good news.

It's about :
mail.identity.idXXXX.htmlSigText
mail.identity.idXXXX.htmlSigformat
mail.identity.idXXXX.attach_signature
mail.identity.idXXXX.sig_file (and update mail.identity.idXXXX.sig_file-rel)
mail.identity.idXXXX.sign_mail

Waiting the new API, i use expirment API.

Thanks Mark

Comment 6

[John Bieling (:TbSync)]

Attachment: Bug 1642690 - Add accounts.getIdentity and accounts.updateIdentity and add signature to MailIdentity. r=darktrojan

Comment 7

[John Bieling (:TbSync)]

The patch allows getting and updating identities, including the signature. From the list in Comment 4 I included:

• mail.identity.idXXXX.htmlSigText
• mail.identity.idXXXX.htmlSigformat

What are the others about?

Comment 8

[kam193]

Hi,
I'm pleased for this change. Settings you add are perfect for me, it's what I'm using in my extension (https://github.com/kam193/thbrd-signature/blob/master/signature-extension/implementation.js)

I'd be happy to do a migration to the new API & verify if it replaces my experimental APIs.

Comment 9

[John Bieling (:TbSync)]

Attachment: Bug 1642690 - Add identities API including signature support, update/delete/create functions and events. r=darktrojan

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf81ba928b15
Add identities API including signature support, update/delete/create functions and events. r=darktrojan