1642731 - Turn excessive calls to document.l10n.formatValue to a single document.l10n.formatValues call

Status: RESOLVED FIXED

(Firefox :: Page Info Window, task)

Description

[Dave Townsend [:mossop] (PTO until Aug 21st)]

This is a little excessive: https://searchfox.org/mozilla-central/rev/559b25eb41c1cbffcb90a34e008b8288312fcd25/browser/base/content/pageinfo/pageInfo.js#291-303

Comment 1

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Attachment: Bug 1642731: Turn excessive calls to document.l10n.formatValue to a single document.l10n.formatValues call. r=Gijs!

Rather than sending the strings down to the content process and back up instead
have the content process just send the media type which when prefixed with
media- gives us the fluent ID for the string. Ideally this would allow us to
just set that as the data-l10n-id for the items but since this tree is
generated by a custom nsITreeView implementation that isn't an option so this
still caches the strings on load.

A single formatValues call will be more performant.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffe433d59e0d
Turn excessive calls to document.l10n.formatValue to a single document.l10n.formatValues call. r=Gijs

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ffe433d59e0d