1642803 - The notifications aren't re-enabled after ending screen-share, but only after ending call

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Note

• The notifications are only blocked after starting screen-share, but they don't end when screen-sharing is stopped, but only when the call is ended.

Affected versions

• Beta v77.0b8
• Nightly v78.0a1

Affected platforms

• Windows 10

Steps to reproduce
Required prefs:

• Flip privacy.webrtc.allowSilencingNotifications to true
• Flip privacy.webrtc.legacyGlobalIndicator to false

1. Engage in a Video Call in the expected web-app.
2. Click the button to share your screen view.
3. Select the option to share a window/screen from the drop-down.
4. Select the checkbox to silence notifications and allow screen share permission.
5. Receive a notification. (a tool to use: https://davidwalsh.name/demo/notifications-api.php)
   Observe: Notifications are blocked as expected.
6. Stop screen-sharing.
7. Receive a notification. (a tool to use: https://davidwalsh.name/demo/notifications-api.php)

Expected result

• The notification is displayed because the user is not sharing the screen.

Actual result

• The notification is NOT displayed;
• However notifications received after the call ends are being displayed.

Regression range

• Feature implementation issue.

Additional notes

• This issue has been found to reproduce with Zoom, Meets on Windows 10 & 7 (so far).
• This bug description will suffer changes (updates) until the feature testing is completed.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1642803 - Cancel notification silencing once the display share is over. r?pbz!

Depends on D78120

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48f9a72a27a0
Cancel notification silencing once the display share is over. r=pbz

Comment 3

[Razvan Maries]

Backed out for perma failures on browser_devices_get_user_media_in_xorigin_frame.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=Al6zHj-_T6CdoeKJon48fg-0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cmochitests%2Ctest-linux1804-64-asan%2Fopt-mochitest-browser-chrome-e10s-11%2Cm%28bc11%29&revision=48f9a72a27a0a62ec95bd486301cd0934590cb04

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305648032&repo=autoland&lineNumber=2075

Backout: https://hg.mozilla.org/integration/autoland/rev/1bdae12bd733dbbfa70de8d2f8f5761ecdbc5f33

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a065a1c9a10
Cancel notification silencing once the display share is over. r=pbz

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4a065a1c9a10

Comment 6

[Daniel Bodea [:danibodea]]

I can confirm this issue is fixed in Nightly v79.0a1 from 2020-06-17 on Windows 10, Ubuntu 18.04.4LTS and Mac OS 10.12.6