Closed Bug 1642990 Opened 9 months ago Closed 6 months ago

Ensure we are not writing/maintaining legacy search engine configuration data in the cache

Categories

(Firefox :: Search, task, P3)

task
Points:
2

Tracking

()

RESOLVED FIXED
82 Branch
Iteration:
82.1 - Aug 24 - Sep 6
Tracking Status
firefox82 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

I suspect that once bug 1619926 is done, we shouldn't be writing any legacy configuration information to the cache.

However, we should have a quick check, and remove anything that we no longer need.

Type: defect → task
Flags: needinfo?(dharvey)
Severity: N/A → S3
Iteration: --- → 82.1 - Aug 24 - Sep 6
Assignee: nobody → standard8

appVersion is no longer used with modern config.
Also realised we could remove 'this._metaData' in the search service as it isn't used now.
Tidied up the load*FromCache functions as we don't need to pass the cache to them - just the engines. This makes the cache use clearer.
Also simplified getting the verified attribute when finding the default engine.

Depends on D88277

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/426d017d7e46
Stop writing appVersion to the search cache, clean up accesses. r=daleharvey
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/991fec7d58b3
Stop writing appVersion to the search cache, clean up accesses. r=daleharvey
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.