1642990 - Ensure we are not writing/maintaining legacy search engine configuration data in the cache

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

I suspect that once bug 1619926 is done, we shouldn't be writing any legacy configuration information to the cache.

However, we should have a quick check, and remove anything that we no longer need.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:daleharvey, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1642990 - Stop writing appVersion to the search cache, clean up accesses. r?daleharvey!

appVersion is no longer used with modern config.
Also realised we could remove 'this._metaData' in the search service as it isn't used now.
Tidied up the load*FromCache functions as we don't need to pass the cache to them - just the engines. This makes the cache use clearer.
Also simplified getting the verified attribute when finding the default engine.

Depends on D88277

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/426d017d7e46
Stop writing appVersion to the search cache, clean up accesses. r=daleharvey

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/991fec7d58b3
Stop writing appVersion to the search cache, clean up accesses. r=daleharvey

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/991fec7d58b3