Remove legacy search configuration code and the preference (modernConfig = false)
Categories
(Firefox :: Search, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox82 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(8 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Once we're shipping the modern search config, we should go through the code and remove the browser.search.modernConfig
preference, and remove all the code associated with this being false.
We should also tidy up the toolkit/components/search xpcshell-tests to not run both legacy & modern configurations.
I don't think there's any strings that will be removed by this, but we should keep an eye out anyway.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Depends on D87894
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D88017
Assignee | ||
Comment 3•4 years ago
|
||
Also remove DirectoryProvider as it is now unused.
Depends on D88018
Assignee | ||
Comment 4•4 years ago
|
||
Depends on D88019
Assignee | ||
Comment 5•4 years ago
|
||
Depends on D88020
Assignee | ||
Comment 6•4 years ago
|
||
Depends on D88021
Assignee | ||
Comment 7•4 years ago
|
||
Depends on D88022
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af69a4896f2f Remove legacy search configuration code from the search service. r=daleharvey,geckoview-reviewers,agi https://hg.mozilla.org/integration/autoland/rev/9260b6620943 Remove ensure known region checks from search service. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/d665885bc912 Remove distribution search directory provider definitions. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/d89793e9d17d Change test_validate_engines.js to work with the modern configuration. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/786164c461ae Remove old search config list.json files from tests as they aren't necessary anymore. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/bc9d3e210fe7 Remove remnants of Search geo-location handling now it is handled by Region.jsm. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/7dfeb065a385 Remove test_distribution_unreadable.js as distribution engines are no longer read from a directory. r=daleharvey
Assignee | ||
Comment 9•4 years ago
|
||
Android doesn't use sessionstore-windows-restored and currently doesn't use the search service (which fails for it at the moment).
Comment 10•4 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42f8d51c95b8 Remove legacy search configuration code from the search service. r=daleharvey,geckoview-reviewers,agi https://hg.mozilla.org/integration/autoland/rev/52524fcada13 Remove ensure known region checks from search service. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/d7e51306a5e8 Remove distribution search directory provider definitions. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/2f92a37d784e Change test_validate_engines.js to work with the modern configuration. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/1c0603da9195 Remove old search config list.json files from tests as they aren't necessary anymore. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/fca61916c538 Remove remnants of Search geo-location handling now it is handled by Region.jsm. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/54874b9093c8 Remove test_distribution_unreadable.js as distribution engines are no longer read from a directory. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/ca6f8679bac0 Disable test_firstRun of test_TelemetryReportingPolicy.js on android. r=chutten
Comment 11•4 years ago
|
||
Pushed by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f6cee192a480 Properly disable test_firstRun of test_TelemetryReportingPolicy.js on android. a=fix
Comment 12•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/42f8d51c95b8
https://hg.mozilla.org/mozilla-central/rev/52524fcada13
https://hg.mozilla.org/mozilla-central/rev/d7e51306a5e8
https://hg.mozilla.org/mozilla-central/rev/2f92a37d784e
https://hg.mozilla.org/mozilla-central/rev/1c0603da9195
https://hg.mozilla.org/mozilla-central/rev/fca61916c538
https://hg.mozilla.org/mozilla-central/rev/54874b9093c8
https://hg.mozilla.org/mozilla-central/rev/ca6f8679bac0
https://hg.mozilla.org/mozilla-central/rev/f6cee192a480
Description
•