Closed Bug 1619926 Opened 4 years ago Closed 4 years ago

Remove legacy search configuration code and the preference (modernConfig = false)

Categories

(Firefox :: Search, task, P3)

task
Points:
5

Tracking

()

RESOLVED FIXED
82 Branch
Iteration:
82.1 - Aug 24 - Sep 6
Tracking Status
firefox82 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(8 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

Once we're shipping the modern search config, we should go through the code and remove the browser.search.modernConfig preference, and remove all the code associated with this being false.

We should also tidy up the toolkit/components/search xpcshell-tests to not run both legacy & modern configurations.

I don't think there's any strings that will be removed by this, but we should keep an eye out anyway.

Severity: normal → N/A
Priority: P5 → P3
Blocks: 1642990
Blocks: 1643471
Blocks: 1596398
Assignee: nobody → standard8
Iteration: --- → 80.1 - June 29 - July 12
Blocks: 1586580
Blocks: 1590254
Iteration: 80.1 - June 29 - July 12 → 81.1 - July 27 - Aug 09
Depends on: 1656840
Depends on: 1658920
No longer blocks: 1586580
No longer blocks: 1590254
Iteration: 81.1 - July 27 - Aug 09 → 82.1 - Aug 24 - Sep 6
Depends on: 1660530

Also remove DirectoryProvider as it is now unused.

Depends on D88018

Depends on: 1661670
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af69a4896f2f
Remove legacy search configuration code from the search service. r=daleharvey,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/9260b6620943
Remove ensure known region checks from search service. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/d665885bc912
Remove distribution search directory provider definitions. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/d89793e9d17d
Change test_validate_engines.js to work with the modern configuration. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/786164c461ae
Remove old search config list.json files from tests as they aren't necessary anymore. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/bc9d3e210fe7
Remove remnants of Search geo-location handling now it is handled by Region.jsm. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/7dfeb065a385
Remove test_distribution_unreadable.js as distribution engines are no longer read from a directory. r=daleharvey

Android doesn't use sessionstore-windows-restored and currently doesn't use the search service (which fails for it at the moment).

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42f8d51c95b8
Remove legacy search configuration code from the search service. r=daleharvey,geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/52524fcada13
Remove ensure known region checks from search service. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/d7e51306a5e8
Remove distribution search directory provider definitions. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/2f92a37d784e
Change test_validate_engines.js to work with the modern configuration. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/1c0603da9195
Remove old search config list.json files from tests as they aren't necessary anymore. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/fca61916c538
Remove remnants of Search geo-location handling now it is handled by Region.jsm. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/54874b9093c8
Remove test_distribution_unreadable.js as distribution engines are no longer read from a directory. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/ca6f8679bac0
Disable test_firstRun of test_TelemetryReportingPolicy.js on android. r=chutten
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6cee192a480
Properly disable test_firstRun of test_TelemetryReportingPolicy.js on android. a=fix
Blocks: 1755474
You need to log in before you can comment on or make changes to this bug.