1643015 - The Global Sharing Indicator's button colors are not according to design

Status: RESOLVED INVALID

(Firefox :: Site Permissions, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Note

• The Camera and Microphone buttons are a shade darker than the rest of the overlay's frame. They should have the same color as the frame, unless the design changes.
• Only the minimize button has a darker shade than the rest of the overlay.

Affected versions

• Nightly v78.0a1
• Beta v77.0 (RC)

Affected platforms

• ALL

Steps to reproduce
Required prefs:

• Flip privacy.webrtc.allowSilencingNotifications to true
• Flip privacy.webrtc.legacyGlobalIndicator to false

1. Engage in a video conference.
2. Share the microphone and camera, preferably the screen, also.
3. Observe the Overlay's default color.

Expected result

• The camera and microphone buttons should be the same color as the frame; only the minimize button should be darker.

Actual result

• The camera and microphone have a slightly darker color, like the minimize button.

Regression range

• This is an implementation issue.

Additional notes

• This issue could be worked-around along with bug 1641620 and bug 1640203 if a nice looking border would be implemented around the whole Overlay.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: button-color-differences.png

Comment 2

[Daniel Bodea [:danibodea]]

This issue does not affect the newly implemented design currently seen in Nightly v79.0a1. The button colors are according to the old design now (the mic/camera button has the same color as the frame of the Global Sharing Overlay and the minimize button has a darker color to it.

However, the newly implemented design is now different from the initial mock-ups so it should probably not apply to Nightly v79.0a1 anyway.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Bodea Daniel [:danibodea] from comment #2)

This issue does not affect the newly implemented design currently seen in Nightly v79.0a1. The button colors are according to the old design now (the mic/camera button has the same color as the frame of the Global Sharing Overlay and the minimize button has a darker color to it.

However, the newly implemented design is now different from the initial mock-ups so it should probably not apply to Nightly v79.0a1 anyway.

In that case, I think this is INVALID at this point. Thanks!