Closed Bug 1643058 Opened 1 year ago Closed 1 year ago

webrtc web-platform-tests need a cleanup

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla79

Tracking Flags:

Tracking

Status

firefox79

---

fixed

People

(Reporter: bwc, Assigned: bwc)

References

Details

Attachments

(8 files)

Bug 1643058: Clean up ini files. 1 year ago Byron Campen [:bwc] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1643058: Try to work around bug 1641237 by adding some restart-after on longer tests. 1 year ago Byron Campen [:bwc] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1643058: Clean up PeerConnections in these tests. 1 year ago Byron Campen [:bwc] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1643058: Mark these tests as long, because they do ICE. 1 year ago Byron Campen [:bwc] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1643058: Timestamp mDNS lookups. 1 year ago Byron Campen [:bwc] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1643058: Add a restart-after to avoid timeouts in the next test on win 7 debug. 1 year ago Byron Campen [:bwc] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1643058: Make these tests fail instead of timing out if ICE fails. 1 year ago Byron Campen [:bwc] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1643058: Add bug link for this failure. 1 year ago Byron Campen [:bwc] 47 bytes, text/x-phabricator-request		Details \| Review

Byron Campen [:bwc]

Assignee

Description

•

1 year ago

There are lots of disabled webrtc wpt, with no bug numbers in the ini files. The ini files need to be evaluated, tests re-enabled if possible, and bug links added if not.

Byron Campen [:bwc]

Assignee

Comment 1

•

1 year ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7883b898d7c9faa9ef4e2bc05f8fc76ac1c6d035

Byron Campen [:bwc]

Assignee

Comment 2

•

1 year ago

Seeing lots of instances of bug 1641788 in that push.

Depends on: 1641788

Byron Campen [:bwc]

Assignee

Comment 3

•

1 year ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfba37f3d049bb81e58b413080b28ad300f2ecdb

Byron Campen [:bwc]

Assignee

Comment 4

•

1 year ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34292503a9bb141def47d2875f2767ddc569fd5c

Byron Campen [:bwc]

Assignee

Comment 5

•

1 year ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0824379ff4fee9ec80a6f2b471f6ac9ba812e776

Byron Campen [:bwc]

Assignee

Updated

•

1 year ago

Comment 6

•

1 year ago

•

Edited

Push without fuzzy --full: Only seeing known intermittents. https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd392d1975c6e8ac19e8d77cc984d24fb4ae2ac9

Push with fuzzy --full: Mostly known intermittents here, but there are some failures on android that I don't see in bugzilla anywhere: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1edc0bf860fc9a0e8bc43812e5b31c7e777e5a1

Here's a push on the base revision to check out those Android failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=32debcb7d02700c2c724ac230492a103488e42d6

Byron Campen [:bwc]

Assignee

Comment 7

•

1 year ago

•

Edited

The failures on fuzzy --full android happen on the base revision too. So, try looks good. Let's see if that holds up after a rebase!

Byron Campen [:bwc]

Assignee

Comment 8

•

1 year ago

•

Edited

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7999e830f67f35f71d0722c473ae1a15157ad81

fuzzy --full: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bf417ca1cb6c748b6f9c0516918ce6a1069bb13

Byron Campen [:bwc]

Assignee

Comment 9

•

1 year ago

Attached file Bug 1643058: Clean up ini files. — Details

Byron Campen [:bwc]

Assignee

Comment 10

•

1 year ago

Attached file Bug 1643058: Try to work around bug 1641237 by adding some restart-after on longer tests. — Details

Depends on D79527

Byron Campen [:bwc]

Assignee

Comment 11

•

1 year ago

Attached file Bug 1643058: Clean up PeerConnections in these tests. — Details

Depends on D79528

Byron Campen [:bwc]

Assignee

Comment 12

•

1 year ago

Attached file Bug 1643058: Mark these tests as long, because they do ICE. — Details

Depends on D79529

Byron Campen [:bwc]

Assignee

Comment 13

•

1 year ago

Attached file Bug 1643058: Timestamp mDNS lookups. — Details

Depends on D79530

Byron Campen [:bwc]

Assignee

Comment 14

•

1 year ago

Attached file Bug 1643058: Add a restart-after to avoid timeouts in the next test on win 7 debug. — Details

Depends on D79531

Byron Campen [:bwc]

Assignee

Comment 15

•

1 year ago

Try looks good.

Byron Campen [:bwc]

Assignee

Comment 16

•

1 year ago

•

Edited

Try from rebase:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c5a530a0eb86690e2dda358c9f6a1dfcd33e8b0

With --full: https://treeherder.mozilla.org/#/jobs?repo=try&revision=29be5cd47d90094d7f45ce5d55d17c83b4c97288

Byron Campen [:bwc]

Assignee

Comment 17

•

1 year ago

Lots of bug 1645663 in those pushes. Also seeing some intermittents that bug 1645219 fixes.

Byron Campen [:bwc]

Assignee

Comment 18

•

1 year ago

•

Edited

Hit merge conflicts when trying to land, so here are some more try pushes!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0dcb3cba323c512c5930e8368fe9c16d94952a61

Byron Campen [:bwc]

Assignee

Updated

•

1 year ago

Comment 19

•

1 year ago

•

Edited

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ac5a4ae2e5306ea26659b9a6e9b2038ba1b48d0

Running full wpt suite, not just webrtc: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ff29dadfe1514b2e059d381ced3ffd570d864e0

fuzzy --full: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a64b9fef305d1aecc17daaf3134b3748ca57cdfc

Byron Campen [:bwc]

Assignee

Comment 20

•

1 year ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8778f5cb6315ee7c810295dd746229c27fbeac2b

Byron Campen [:bwc]

Assignee

Comment 21

•

1 year ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b726e3034fe0251d08363b555111687bfd290d7a

Pulsebot

Comment 22

•

1 year ago

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6edf6df8183
Clean up ini files. r=jib
https://hg.mozilla.org/integration/autoland/rev/c4f71ccf6934
Try to work around bug 1641237 by adding some restart-after on longer tests. r=jib
https://hg.mozilla.org/integration/autoland/rev/7d90312af10f
Clean up PeerConnections in these tests. r=jib
https://hg.mozilla.org/integration/autoland/rev/12c6d279b173
Mark these tests as long, because they do ICE. r=jib
https://hg.mozilla.org/integration/autoland/rev/fcc0942206d9
Timestamp mDNS lookups. r=dminor
https://hg.mozilla.org/integration/autoland/rev/6dd69c93d9e2
Add a restart-after to avoid timeouts in the next test on win 7 debug. r=jib

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 23

•

1 year ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24323 for changes under testing/web-platform/tests

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 24

•

1 year ago

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/24323
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/G9FV0ksDRWeATECNuafG7A)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Updated

•

1 year ago

Flags: needinfo?(docfaraday)

Dorel Luca [:dluca]

Comment 25

•

1 year ago

Backed out 6 changesets (bug 1643058) for WPT failures in webrtc/RTCRtpReceiver-getSynchronizationSources.https.html. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307330485&repo=autoland&lineNumber=11620

Push with failure:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=6dd69c93d9e2a9f06e7404f4655207adf6a22fdd

Backout:
https://hg.mozilla.org/integration/autoland/rev/8245e9943d9de53b9f3a3a3193704b9b4d49400f

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 26

•

1 year ago

Upstream PR was closed without merging

Byron Campen [:bwc]

Assignee

Comment 27

•

1 year ago

Yeah, the merge was bad. Trying again...

Flags: needinfo?(docfaraday)

Byron Campen [:bwc]

Assignee

Comment 28

•

1 year ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b3d91734d0185f4e5bf438d6c4dd1961120099e

Byron Campen [:bwc]

Assignee

Comment 29

•

1 year ago

•

Edited

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf0156fd361451cb06a56e424702d3b09a69ea33

Whole suite: https://treeherder.mozilla.org/#/jobs?repo=try&revision=58f33f8c190ce768a548822a60b97b8bf1c83504

Noemi Erli[:noemi_erli]

Updated

•

1 year ago

Blocks: 1648199

Byron Campen [:bwc]

Assignee

Comment 30

•

1 year ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=88f03cafe97ac8dc1e10c947b8bd54191ce04434

Byron Campen [:bwc]

Assignee

Comment 31

•

1 year ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb5941e5e5422fd141e5a4a51c35815fc2f5c6b2

Byron Campen [:bwc]

Assignee

Comment 32

•

1 year ago

Attached file Bug 1643058: Make these tests fail instead of timing out if ICE fails. — Details

Depends on D79532

Byron Campen [:bwc]

Assignee

Comment 33

•

1 year ago

Attached file Bug 1643058: Add bug link for this failure. — Details

Depends on D80947

Pulsebot

Comment 34

•

1 year ago

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ebad65f70e2d
Clean up ini files. r=jib
https://hg.mozilla.org/integration/autoland/rev/b32e18c3d542
Try to work around bug 1641237 by adding some restart-after on longer tests. r=jib
https://hg.mozilla.org/integration/autoland/rev/4767df198c29
Clean up PeerConnections in these tests. r=jib
https://hg.mozilla.org/integration/autoland/rev/cf062b9c00b4
Mark these tests as long, because they do ICE. r=jib
https://hg.mozilla.org/integration/autoland/rev/9c677d996512
Timestamp mDNS lookups. r=dminor
https://hg.mozilla.org/integration/autoland/rev/141ade17eb3c
Add a restart-after to avoid timeouts in the next test on win 7 debug. r=jib
https://hg.mozilla.org/integration/autoland/rev/36f54439ad2e
Make these tests fail instead of timing out if ICE fails. r=jib
https://hg.mozilla.org/integration/autoland/rev/78d7201bf2a0
Add bug link for this failure. r=jib

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 35

•

1 year ago

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/24323
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/Z-QCfGlhS4Skt_ZpISLsdA)

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Updated

•

1 year ago

Flags: needinfo?(docfaraday)

Byron Campen [:bwc]

Assignee

Comment 36

•

1 year ago

/webrtc/RTCPeerConnection-createDataChannel.html seems to be having unexpected errors on Chrome, but the only change there was marking the test as long.
/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is the same story.
/webrtc/datachannel-emptystring.html just had some necessary cleanup added.
/webrtc/no-media-call.html just had some necessary cleanup added.

Looks like Chrome needs to update their test expectations.

Flags: needinfo?(docfaraday)

Atila Butkovits

Comment 37

•

1 year ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ebad65f70e2d
https://hg.mozilla.org/mozilla-central/rev/b32e18c3d542
https://hg.mozilla.org/mozilla-central/rev/4767df198c29
https://hg.mozilla.org/mozilla-central/rev/cf062b9c00b4
https://hg.mozilla.org/mozilla-central/rev/9c677d996512
https://hg.mozilla.org/mozilla-central/rev/141ade17eb3c
https://hg.mozilla.org/mozilla-central/rev/36f54439ad2e
https://hg.mozilla.org/mozilla-central/rev/78d7201bf2a0

Status: NEW → RESOLVED

Closed: 1 year ago

status-firefox79: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla79

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Comment 38

•

1 year ago

Upstream PR merged by jgraham

Byron Campen [:bwc]

Assignee

Updated

•

11 months ago

Duplicate of this bug: 1643947

You need to log in before you can comment on or make changes to this bug.