1643079 - Normandy initialize is called twice with --first-startup

Status: RESOLVED WONTFIX

(Firefox :: Normandy Client, defect, P1)

Description

[Michael Cooper [:mythmon]]

When Firefox is run with the --first-startup flag, such as when a new version is installed, Normandy's initialization sequence is triggered twice. First by FirstStartup.jsm, and second by BrowserGlue.jsm.

This is definitely wrong, and has caused on specific problem that we know of. If a rollout is active, it will be graduated immediately, since the second initialization will see the results of the first.

Normandy's initialization sequence should be idempotent.

Comment 1

[Michael Cooper [:mythmon]]

Attachment: Bug 1643079 - Normandy initialize should be idempotent r=rhelmer!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45c377f2f2f1
Normandy initialize should be idempotent r=rhelmer

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/45c377f2f2f1

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8278280311bf
Backed out changeset 45c377f2f2f1 on request by dev due to regression of 1643499

Comment 5

[Michael Cooper [:mythmon]]

This is not as critical as I first thought.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/8278280311bf

Comment 7

[Michael Cooper [:mythmon]]

When re-implementing this, care should be taken to avoid the regression in bug 1643499 happening again.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last months and this bug has priority 'P1'.
:barret, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Barret Rennie [:barret] (they/them)]

ni? to investigate when back from PTO

Comment 10

[Barret Rennie [:barret] (they/them)]

Given this affects studies and Normandy is being deprecated, I'm going to classify this as WONTFIX.