Open Bug 1643234 Opened 4 years ago Updated 2 years ago

Multiple node executables installed as part of bootstrap

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Tracking

(Not tracked)

People

(Reporter: Mardak, Unassigned)

References

Details

In testing bug 1641863 now that it's in m-c, I noticed bootstrap installing node@14.4.0 via brew which is done as part of bug 1424921. I believe since bug 1481693, the mozbuild node can be used, and a quick check seems to confirm:

$ head -1 eslintrc.js
console.log(process.argv);

$ ./mach lint -l eslint
[ '~/.mozbuild/node/bin/node',
  '~/mozilla-central/node_modules/eslint/bin/eslint.js',

Does this mean the node installed by brew and related for other platforms isn't necessary anymore ?

Flags: needinfo?(standard8)
Depends on: 1641863
No longer depends on: 1547823

As far as I know we shouldn't need it installed by Brew.

Flags: needinfo?(standard8)

Agreed that it should go away. That said, there is one thing that it may provide for some number of developers (in the sense that some folks might not ever both installing it): a version of node in their PATH (eg a place where they can currently install stuff globally, like jsdoc. Of course, it's a different version of node, and the jsdoc thing should go away with vendoring. But we might want to hold off until the vendoring happens. Or maybe not.

Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.