1643253 - Collect more telemetry data about the Application panel usage

Status: RESOLVED FIXED

(DevTools :: Application Panel, task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Basic telemetry about the Application panel usage (panel open/close) where added in bug 1451734.

This is a follow up bug that should be used to introduce additional telemetry for:

• Navigation in the side bar (Service Workers/Manifest)
• Clicking on Debug/Start/Unregister buttons

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Some links into the source code for inspiration:

• Shared Telemetry object used to send telemetry events
  https://searchfox.org/mozilla-central/rev/7cadba1d8b8feaec4615f5bb98aac4b8a719793c/devtools/client/shared/telemetry.js#27

• Network panel middleware handling Redux actions and storing related telemetry data
  https://searchfox.org/mozilla-central/rev/7cadba1d8b8feaec4615f5bb98aac4b8a719793c/devtools/client/netmonitor/src/middleware/event-telemetry.js#50-103

• Inspector sidebar handling tab selection change and storing telemetry:
  https://searchfox.org/mozilla-central/rev/7cadba1d8b8feaec4615f5bb98aac4b8a719793c/devtools/client/inspector/toolsidebar.js#226

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Also note that clicking on the Debug button should use an existing enter event's start_state key

https://searchfox.org/mozilla-central/rev/7cadba1d8b8feaec4615f5bb98aac4b8a719793c/toolkit/components/telemetry/Events.yaml#1247

Honza

Comment 3

[Belén [:ladybenko]]

Attachment: Bug 1643253 - Part 1: Add telemetry middleware to record application panel events

Comment 4

[Belén [:ladybenko]]

Attachment: Bug 1643253 - Part 2: Add telemetry mochitests

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: request.md

Comment 6

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9161580 [details]
request.md

r+, thanks!

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way? Click the documentation link provided in Q6 and ensure it is publicly accessible and does or will contain documentation for the data collection.

Yes, in Events.yaml and the probe dictionary.

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, the Firefox telemetry opt-out.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Harald's on the hook as usual.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, technical data.

5) Is the data collection request for default-on or default-off?

Default-on.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) 

No, permanent collection.

9) Does the data collection use a third-party collection tool?

No.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f63b52ffc53a
Part 1: Add telemetry middleware to record application panel events r=jdescottes,janerik
https://hg.mozilla.org/integration/autoland/rev/bb3999a4e5cf
Part 2: Add telemetry mochitests r=jdescottes,Honza

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f63b52ffc53a
https://hg.mozilla.org/mozilla-central/rev/bb3999a4e5cf