1643285 - Daily 79.0a1 throws an XML Parse error on content/systemIntegrationDialog.xhtml

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

When starting Daily, it throws an XML Parse error on content/systemIntegrationDialog.xhtml.
In bug 1615501 the processing of this file has changed and it is not preprocessed anymore, therefore the preprocessor directives should be removed and the license should be converted to a html-comment <!-- .... -->.

Comment 1

[Magnus Melin [:mkmelin]]

So this needs to be reverted: https://hg.mozilla.org/comm-central/diff/56288941d6185b1a281af725996db62324e8c79c/mail/base/jar.mn

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: 1643285-xml-parse.diff

Thanks for the bug report.
We don't need to preprocess that file anymore since the platform's based string variations are handled in Fluent.
Updated the top comment to use a regular html comment tag.

Comment 3

[Robert Hartmann]

Is this the bugreport for the startup message:

XML Parsing Error: not well-formed
Location: chrome://messenger/content/systemIntegrationDialog.xhtml
Line Number 2, Column 2:
# -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 4 -*-
-^

79.0a1 (2020-06-04) (64-bit)
BuildID 20200604105934

Comment 4

[Onno Ekker [:nONoNonO UTC+1]]

(In reply to Robert Hartmann from comment #3)

Is this the bugreport for the startup message:

XML Parsing Error: not well-formed
Location: chrome://messenger/content/systemIntegrationDialog.xhtml
Line Number 2, Column 2:
# -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 4 -*-
-^

79.0a1 (2020-06-04) (64-bit)
BuildID 20200604105934

Yep, that was the error message... I already clicked it away and had Dutch localization, so I didn't have the exact message anymore, but that was it.

Comment 5

[Alessandro Castellani [:aleca]]

This needs to be uplifted for beta also.

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9154269 [details] [diff] [review]
1643285-xml-parse.diff

The second and third line need an extra space before the "-".

Comment 7

[Alessandro Castellani [:aleca]]

Attachment: 1643285-xml-parse.diff

Thanks, patch updated.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bb0273cc41d3
Fix XML parse error in systemIntegrationDialog.xhtml. r=darktrojan

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9154452 [details] [diff] [review]
1643285-xml-parse.diff

Approvedfor beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/ad88c408fb6d