Remove YCbCrBuffer::Plane::mOffset
Categories
(Core :: Audio/Video, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: bryce, Assigned: bryce)
Details
Attachments
(1 file, 1 obsolete file)
We can remove the mOffset member from YCbCrBuffer::Plane and instead just roll any offset into the data pointer when we store the planes.
Using an offset makes sense if we only store a single pointer and then offset into each plane, but since each plane has its own pointer, we don't need the offset.
|
Assignee | |
Comment 1•5 years ago
|
||
Because we store each plane's data pointer we don't need to store a separate
offset, we can just roll that offset into the pointer for that plane.
This helps remove a lot of code where we're not using the offset anyway, and in
the Chromium CDM case we simply roll the offset into our data pointer.
|
|
Assignee | |
Comment 2•5 years ago
|
||
The CDM header bump has moved some enums, as well as using enum classes instead
of old style enums. This patch updates consumers of these enums to be compatible
with the new headers.
Drive by remove using namespace cdm from a couple of files as
- In some places I'd already been using fully qualified names.
- I prefer the fully qualified names as they make it clear when enums are coming
from the cdm namespace andcdm::is not a particularly more verbose thing to
have on identifiers.
Depends on D78341
|
|
Assignee | |
Comment 3•5 years ago
|
||
Whoops, looks like patch 2 there is on the wrong bug. Fixing.
|
||
Comment 4•5 years ago
|
||
Comment on attachment 9154267 [details]
Bug 1643375 - Update enums that have changed with CDM header bump. r?alwu,dminor
Revision D78343 was moved to bug 1623651. Setting attachment 9154267 [details] to obsolete.
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•