1643411 - Video playback freezes while audio continues on MacOS

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[kud]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

On Firefox Nightly, videos on Netflix or YouTube don't work well.

Actual results:

I've got the sound but the image is frozen on the first sample.

Like for instance, if you change the progress bar, you'll get the first image and after it's frozen.

Expected results:

Working correctly

Comment 1

[kud]

It works well on Instagram, Twitter, Tiktok.

For the moment I only have this issue on Netflix and YouTube.

Encoding issue?

Comment 2

[kud]

Just tried on 76.0.1 (64-bit), and it works.

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

• Could you navigate to about:support and copy that info onto this bug?
• Could you use the Firefox profiler with the media preset to capture a profile of the bug taking place? It would also be useful if you could capture a profile on another site where the bug doesn't happen.

Comment 4

[kud]

Hey Bryce, is it ok if we continue the discussion to this one? https://bugzilla.mozilla.org/show_bug.cgi?id=1643531

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Yes, though it would be useful to track information in this bug until it's clear the issues are duplicates. I suspect they are the same issue, but if they're not it will make them harder to track by having the info in one bug.

Comment 6

[kud]

Okay. :)

I'll submit my about:support so.

Comment 7

[kud]

Attachment: Application Basics

Comment 8

[kud]

This one on youtube doesn't work: https://share.firefox.dev/3dQENn6
This one on tiktok works: https://share.firefox.dev/2A5ekDG

Comment 9

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Thanks, appreciate it!

Comment 10

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Could you try using mozregression-gui to see if we can further identify what change introduced the issue?

Comment 11

[kud]

Wow impressed by the gui version. I knew a bit the command line but the GUI is really efficient.

The full log: https://gist.github.com/kud/1054638e9fd03c40dd8a76f952c0213c

the short one:

2020-06-08T23:45:45.240000: INFO : platform_buildid: 20200528095856
2020-06-08T23:45:45.240000: INFO : platform_changeset: 5e969a4bab421cfb0c9c6816eafd46a3eeb147f5
2020-06-08T23:45:45.240000: INFO : platform_repository: https://hg.mozilla.org/integration/autoland
2020-06-08T23:45:45.241000: INFO : platform_version: 78.0a1
2020-06-08T23:46:04.804000: INFO : b'[Child 32965, MediaDecoderStateMachine #1] WARNING: Decoder=11fa22400 Decode error: NS_ERROR_DOM_MEDIA_FATAL_ERR (0x806e0005) - RefPtr<MediaSourceTrackDemuxer::SamplesPromise> mozilla::MediaSourceTrackDemuxer::DoGetSamples(int32_t): manager is detached.: file /builds/worker/checkouts/gecko/dom/media/MediaDecoderStateMachine.cpp, line 3470'
2020-06-08T23:46:09.341000: INFO : Narrowed integration regression window from [3a5f3040, 079826b7] (3 builds) to [3a5f3040, 5e969a4b] (2 builds) (~1 steps left)
2020-06-08T23:46:09.391000: DEBUG : Starting merge handling...
2020-06-08T23:46:09.391000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=5e969a4bab421cfb0c9c6816eafd46a3eeb147f5&full=1
2020-06-08T23:46:09.391000: DEBUG : redo: attempt 1/3
2020-06-08T23:46:09.392000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=5e969a4bab421cfb0c9c6816eafd46a3eeb147f5&full=1',), kwargs: {}, attempt #1
2020-06-08T23:46:09.415000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2020-06-08T23:46:10.461000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=5e969a4bab421cfb0c9c6816eafd46a3eeb147f5&full=1 HTTP/1.1" 200 None
2020-06-08T23:46:10.519000: DEBUG : Found commit message:
Bug 1628779 - Disable getting the input and output latency on Linux. r=achronop

Differential Revision: https://phabricator.services.mozilla.com/D76899

2020-06-08T23:46:10.520000: DEBUG : Did not find a branch, checking all integration branches
2020-06-08T23:46:10.526000: INFO : The bisection is done.
2020-06-08T23:46:10.527000: INFO : Stopped

good:
app_name: firefox
build_date: 2020-05-28 11:47:05.269000
build_file: /Users/kud/.mozilla/mozregression/persist/3a5f3040fbef-shippable--autoland--target.dmg
build_type: integration
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/HrtLrOomRgS4UlxpqOy5Zg/runs/0/artifacts/public%2Fbuild%2Ftarget.dmg
changeset: 3a5f3040fbef3e0c98aa1462c5c3525b96e3a76d
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3a5f3040fbef3e0c98aa1462c5c3525b96e3a76d&tochange=272e3c98d0029fe73c0a57c45bc3b11ffa0e2bee
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: HrtLrOomRgS4UlxpqOy5Zg

bad:
app_name: firefox
build_date: 2020-05-28 11:53:01.615000
build_file: /Users/kud/.mozilla/mozregression/persist/079826b74356-shippable--autoland--target.dmg
build_type: integration
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QoeGiBfoQpCWHjZPcdMiaQ/runs/0/artifacts/public%2Fbuild%2Ftarget.dmg
changeset: 079826b74356c53b5a396c57d029dfd0647fbd4d
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3a5f3040fbef3e0c98aa1462c5c3525b96e3a76d&tochange=079826b74356c53b5a396c57d029dfd0647fbd4d
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: QoeGiBfoQpCWHjZPcdMiaQ

bad:
app_name: firefox
build_date: 2020-05-28 11:49:24.754000
build_file: /Users/kud/.mozilla/mozregression/persist/5e969a4bab42-shippable--autoland--target.dmg
build_type: integration
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ZqGir-wHR4eoK8udblBULQ/runs/0/artifacts/public%2Fbuild%2Ftarget.dmg
changeset: 5e969a4bab421cfb0c9c6816eafd46a3eeb147f5
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3a5f3040fbef3e0c98aa1462c5c3525b96e3a76d&tochange=5e969a4bab421cfb0c9c6816eafd46a3eeb147f5
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: ZqGir-wHR4eoK8udblBULQ

finished.

Comment 12

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Alex, could you weigh in on the results above?

Comment 13

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Mixed up author and reviewer, shifting NI to Paul.

Comment 15

[kud]

Thank you Bryce :)

Comment 17

[Paul Adenot (:padenot)]

Unlikely, this patch set is only affecting the MTG, that youtube doesn't use.

Comment 18

[Paul Adenot (:padenot)]

I'm trying something in bug 1644362.

Comment 19

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

If anyone else experiencing the bug can also verify via mozregression, that would be useful.

For bug 1643788 it looks like youtube was working, while other sites were not. For bug 1643531 it sounds like all videos are not working. Further info that could help differentiate the videos that do and don't work may prove useful. :ckarlof can you confirm that videos on twitter or tiktok or instagram do/don't work?

Comment 21

[kud]

I only tried YouTube during the regression, to be fair. I can retry with more websites if you want?

Comment 22

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

(In reply to Erwann Mest from comment #21)

I only tried YouTube during the regression, to be fair. I can retry with more websites if you want?

Other folks verifying the same regression range would be useful to make sure they are hitting the same bug -- I'd only suggest you try reverify if Paul thinks it's unlikely the regressing bug we have here is the culprit. It looks like there are some changes on the way to see if they fix this (bug 1644362). That should be in nightly in the next day or so, and it would be helpful to see if that fixes the issue once it lands.

Comment 23

[kud]

Okay I see! Thank you :) I can be available on Riot if you need to.

Comment 24

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

(In reply to Erwann Mest from comment #23)

Okay I see! Thank you :) I can be available on Riot if you need to.

That would be appreciated, most of us media folks can be found in the 'Media' room. However, I'm happy to continue discussing on this bug and can ping here once the proposed fix has landed.

Comment 25

[kud]

This is exactly that "Video playback freezes while audio continues on MacOS", thanks for the edit! I should be more clear next time. :)

Comment 26

[kud]

79.0a1 (2020-06-10) (64-bit) fixes it! 🎉

Comment 27

[Paul Adenot (:padenot)]

Attachment: Bug 1643411 - Update cubeb-coreaudio-rs to 4cdbc on beta and revendor. r?#cubeb-reviewers

Comment 28

[Paul Adenot (:padenot)]

Comment on attachment 9155609 [details]
Bug 1643411 - Update cubeb-coreaudio-rs to 4cdbc on beta and revendor. r?#cubeb-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Video playback is broken for some users (unclear of the number, but there are has been duplicates) on macOS.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is restoring the code as it is on release. This also includes a fix for a crashes.
• String changes made/needed: none

Comment 29

[Julien Cristau [:jcristau]]

Comment on attachment 9155609 [details]
Bug 1643411 - Update cubeb-coreaudio-rs to 4cdbc on beta and revendor. r?#cubeb-reviewers

approved for 78.0b6

Comment 30

[Chris Karlof [:ckarlof]]

On 20200607093436, Twitter, Instagram, and Tiktok seem to work, YouTube and Netflix don't.

Comment 31

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Could you test the latest nightly to ensure it fixes the issue you were seeing (in the duped bug), please?

Comment 32

[Chris Karlof [:ckarlof]]

On 20200610043607, all video sites are now working for me.

Comment 33

[Teun van Eijsden]

Yes this fixes https://img-9gag-fun.9cache.com/photo/aeDYbyp_460sv.mp4 (see 1643788) for me also.

Comment 34

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Thanks for confirming!

Comment 35

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/de3cfe1bb1ba

Comment 37

[Peter Magyari (Desktop QA)]

Hi,

According to Comment 26, Comment 32 and Comment 33 the issue has been verified as fixed on Nightly 79.0a1.

Could you guys also verify the fix on the latest Firefox Beta 78?

Thank you!

Comment 38

[Chris Karlof [:ckarlof]]

Video is working for me on Beta, too.

Comment 39

[Peter Magyari (Desktop QA)]

Thanks Chris! I will mark it accordingly.