1643427 - Remove or update probes expiring in Firefox 80: devtools.main.f12_*

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 80 [1].

devtools.main.f12_enabled#f12_enabled
devtools.main.f12_popup_displayed#f12_popup_displayed

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #fx-metrics Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Julian Descottes [:jdescottes]]

References in devtools code: https://searchfox.org/mozilla-central/search?q=f12_&path=devtools&case=true&regexp=false

Those events were only used for the f12 experiment, we should be able to remove them.

Comment 2

[Arnav Verma]

Hey! Could I get added as an assignee, I would like to work on this probe!

Related Files

As suggested by Julian, I will be removing from files:
https://searchfox.org/mozilla-central/source/devtools/client/framework/enable-devtools-popup.js
and https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js

Related Lines

I will be removing lines:
https://searchfox.org/mozilla-central/source/devtools/client/framework/enable-devtools-popup.js#51 (Lines 51-53)
and https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#250 (Lines 248-259)

Comment 3

[Arnav Verma]

Attachment: Remove devtools.main.f12_* probes

Comment 4

[Arnav Verma]

Attachment: Remove devtools.main.f12_* probes

Comment 5

[Julian Descottes [:jdescottes]]

Thanks! Assigning the bug to you.

Can you try to setup Phabricator and submit your patch there? We don't really use splinter to review patches anymore.
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 9215327 [details] [diff] [review]
Remove devtools.main.f12_* probes

Review of attachment 9215327 [details] [diff] [review]:
-----------------------------------------------------------------

Can we also remove the 2 events from the Events.yaml definition file? 
https://searchfox.org/mozilla-central/rev/3de2db87f3c9001ae478318d47a2ca3427574382/toolkit/components/telemetry/Events.yaml#1503-1526

::: devtools/client/framework/enable-devtools-popup.js
@@ -48,4 @@
>      }
>  
>      popup.openPopup(anchor, "bottomcenter topright");
> -    telemetry.recordEvent("f12_popup_displayed", "tools", null, {

follow-up: ultimately we could remove everything related to telemetry in this file. I will file another bug to do that, let's keep this simply about removing the events.

Comment 7

[Julian Descottes [:jdescottes]]

Hi Arnav, can we help you to finish this task?

Comment 8

[Arnav Verma]

Hey Julian,
I Will finish up the task today, so sorry about the delay (got completely distracted from some other work)!

Comment 9

[Arnav Verma]

Attachment: fix:Bug 1643427: remove devtools.main.f12_* r=jdescottes

Comment 10

[Julian Descottes [:jdescottes]]

Hi Arnav,

Do you need help to fold the patches together?
Let us know !

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1643427 - [devtools] Remove devtools.main.f12_* probes and associated code. r=jdescottes.

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

stealing this as part of the 91 release process, hope you don't min Arnav!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/510651537bf8
[devtools] Remove devtools.main.f12_* probes and associated code. r=jdescottes.

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/510651537bf8