Closed Bug 1643427 Opened 3 years ago Closed 1 year ago

Remove or update probes expiring in Firefox 80: devtools.main.f12_*

Categories

(DevTools :: General, task)

task

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: telemetry-probes, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [probe-expiry-alert])

Attachments

(3 files, 1 obsolete file)

The following Firefox probes will expire in the next major Firefox nightly release: version 80 [1].

devtools.main.f12_enabled#f12_enabled
devtools.main.f12_popup_displayed#f12_popup_displayed

What to do about this:

  1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
  2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #fx-metrics Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

References in devtools code: https://searchfox.org/mozilla-central/search?q=f12_&path=devtools&case=true&regexp=false

Those events were only used for the f12 experiment, we should be able to remove them.

Blocks: 1566383
Attachment #9215325 - Attachment is obsolete: true

Thanks! Assigning the bug to you.

Can you try to setup Phabricator and submit your patch there? We don't really use splinter to review patches anymore.
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Assignee: nobody → arnav.verma
Status: NEW → ASSIGNED
Comment on attachment 9215327 [details] [diff] [review]
Remove devtools.main.f12_* probes

Review of attachment 9215327 [details] [diff] [review]:
-----------------------------------------------------------------

Can we also remove the 2 events from the Events.yaml definition file? 
https://searchfox.org/mozilla-central/rev/3de2db87f3c9001ae478318d47a2ca3427574382/toolkit/components/telemetry/Events.yaml#1503-1526

::: devtools/client/framework/enable-devtools-popup.js
@@ -48,4 @@
>      }
>  
>      popup.openPopup(anchor, "bottomcenter topright");
> -    telemetry.recordEvent("f12_popup_displayed", "tools", null, {

follow-up: ultimately we could remove everything related to telemetry in this file. I will file another bug to do that, let's keep this simply about removing the events.
Attachment #9215327 - Flags: review-

Hi Arnav, can we help you to finish this task?

Flags: needinfo?(arnav.verma)

Hey Julian,
I Will finish up the task today, so sorry about the delay (got completely distracted from some other work)!

Flags: needinfo?(arnav.verma)

Hi Arnav,

Do you need help to fold the patches together?
Let us know !

Flags: needinfo?(arnav.verma)

stealing this as part of the 91 release process, hope you don't min Arnav!

Assignee: arnav.verma → nchevobbe
Flags: needinfo?(arnav.verma)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/510651537bf8
[devtools] Remove devtools.main.f12_* probes and associated code. r=jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.