Closed Bug 1643477 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 23998 - Check for first frame in CreateImageBitmap

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 23998 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23998
Details from upstream follow.

Thomas Guilbert <tguilbert@chromium.org> wrote:

Check for first frame in CreateImageBitmap

HTMLVideoElement::CreateImageBitmap is currently rejecting valid calls,
when we have an available first frame, but the ready state hasn't been
updated.

This CL updates CreateImageBitmap to check for a valid frame, which
amounts to having a first frame available.

This CL also updates some WPTs to use preload=auto, to allow video
elements to load without being visible, and yield expected results when
calling CreateImageBitmap.

Bug: 1090960
Change-Id: I21302a9c3433bf8218a75c3f6918bc20f4d36ca3

Reviewed-on: https://chromium-review.googlesource.com/2231453
WPT-Export-Revision: 66c3bf5e14ed270287643157cfd292e5066bd6cf

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Attached file Notable wpt changes
# CI Results

Ran 5 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2479 tests and 1 subtests

## Status Summary

### Firefox
OK     : 500[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 2475[GitHub]
PASS   : 491[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 914[GitHub]
FAIL   : 9[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 1726[GitHub]
TIMEOUT: 2
ERROR  : 3
NOTRUN : 12

### Chrome
OK     : 2476
PASS   : 2578
FAIL   : 75
ERROR  : 3

### Safari
OK     : 2475
PASS   : 924
FAIL   : 1729
ERROR  : 4

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dad5653b96bd6c2ee7f20cffc1744195d408e09)
[GitHub PR Head](https://wpt.fyi/results/?sha=49c344235970a82b065209a23f6438e6d4ceb196&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=49c344235970a82b065209a23f6438e6d4ceb196&label=pr_base)

## Details

### Firefox-only Failures
/html/canvas/element/text-styles/2d.text.font.parse.size.percentage.html
  Canvas test: 2d.text.font.parse.size.percentage: FAIL
/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html
  createImageBitmap from a vector HTMLImageElement resized, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a bitmap HTMLImageElement resized, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLVideoElement from a data URL scaled down, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLCanvasElement scaled down, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a bitmap HTMLImageElement scaled up, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a bitmap HTMLImageElement scaled down, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLVideoElement scaled down, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a Blob scaled down, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a vector HTMLImageElement scaled down, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a Blob scaled up, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLVideoElement scaled up, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLCanvasElement resized, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLVideoElement resized, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLVideoElement from a data URL scaled up, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an ImageBitmap scaled down, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a Blob with negative sw/sh, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an ImageBitmap scaled up, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an ImageBitmap resized, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLCanvasElement scaled up, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a Blob resized, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLVideoElement from a data URL resized, and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a vector HTMLImageElement scaled up, and drawImage on the created ImageBitmap: FAIL
/html/canvas/element/text-styles/2d.text.font.parse.size.percentage.default.html
  Canvas test: 2d.text.font.parse.size.percentage.default: FAIL
/html/canvas/element/text-styles/2d.text.font.relative_size.html
  Canvas test: 2d.text.font.relative_size: FAIL
/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage-closed.html
  attempt to draw a closed ImageBitmap to a 2d canvas throws INVALID_STATE_ERR: FAIL
/html/canvas/element/drawing-text-to-the-canvas/2d.text.measure.fontBoundingBox.html
  Testing fontBoundingBox: FAIL
/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.reload.html
  Canvas test: 2d.drawImage.incomplete.reload: FAIL
/html/canvas/element/compositing/2d.composite.operation.clear.html
  Canvas test: 2d.composite.operation.clear: FAIL
/html/canvas/element/text-styles/2d.text.font.parse.system.html
  System fonts must be computed to explicit values: FAIL
/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html
  createImageBitmap from an HTMLCanvasElement imageOrientation: "none", and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLVideoElement imageOrientation: "none", and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a vector HTMLImageElement imageOrientation: "none", and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a Blob imageOrientation: "none", and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an HTMLVideoElement from a data URL imageOrientation: "none", and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from an ImageBitmap imageOrientation: "none", and drawImage on the created ImageBitmap: FAIL
  createImageBitmap from a bitmap HTMLImageElement imageOrientation: "none", and drawImage on the created ImageBitmap: FAIL
/html/canvas/element/manual/imagebitmap/createImageBitmap-origin.sub.html: TIMEOUT
  unclean HTMLCanvasElement: origin unclear bitmaprenderer.transferFromImageBitmap: NOTRUN
  unclean ImageBitmap: origin unclear getImageData: NOTRUN
  unclean HTMLCanvasElement: origin unclear getImageData: NOTRUN
  unclean ImageBitmap: origin unclear bitmaprenderer.transferFromImageBitmap: NOTRUN
  unclean HTMLCanvasElement: origin unclear 2dContext.drawImage: NOTRUN
  unclean ImageBitmap: origin unclear 2dContext.drawImage: NOTRUN
/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.reload.html
  Canvas test: 2d.pattern.image.incomplete.reload: FAIL
/html/canvas/element/text-styles/2d.text.font.parse.complex.html
  Canvas test: 2d.text.font.parse.complex: FAIL

(See attachment for full changes)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66944f0e6639
[wpt PR 23998] - Check for first frame in CreateImageBitmap, a=testonly
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.