Open Bug 1646754 Opened 2 years ago Updated 1 year ago

New wpt failures in /html/canvas/element/ [text-styles/2d.text.font.parse.size.percentage.html, text-styles/2d.text.font.parse.size.percentage.default.html, text-styles/2d.text.font.relative_size.html, and 10 others]

Categories

(Core :: Canvas: 2D, defect)

defect

Tracking

()

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [wpt])

Syncing wpt PR 23998 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

/html/canvas/element/text-styles/2d.text.font.parse.size.percentage.html
Canvas test: 2d.text.font.parse.size.percentage: FAIL
/html/canvas/element/text-styles/2d.text.font.parse.size.percentage.default.html
Canvas test: 2d.text.font.parse.size.percentage.default: FAIL
/html/canvas/element/text-styles/2d.text.font.relative_size.html
Canvas test: 2d.text.font.relative_size: FAIL
/html/canvas/element/drawing-text-to-the-canvas/2d.text.measure.fontBoundingBox.html
Testing fontBoundingBox: FAIL
/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.reload.html
Canvas test: 2d.drawImage.incomplete.reload: FAIL
/html/canvas/element/compositing/2d.composite.operation.clear.html
Canvas test: 2d.composite.operation.clear: FAIL
/html/canvas/element/text-styles/2d.text.font.parse.system.html
System fonts must be computed to explicit values: FAIL
/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.reload.html
Canvas test: 2d.pattern.image.incomplete.reload: FAIL
/html/canvas/element/text-styles/2d.text.font.parse.complex.html
Canvas test: 2d.text.font.parse.complex: FAIL

New Tests That Don't Pass

/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.zerosource.html
drawImage with zero-sized source rectangle draws nothing without exception: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/element/drawing-text-to-the-canvas/2d.text.measure.advances.html
Testing width advances: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/element/drawing-text-to-the-canvas/2d.text.measure.baselines.html
Testing baselines: FAIL (Chrome: PASS, Safari: FAIL)
/html/canvas/element/drawing-text-to-the-canvas/2d.text.measure.emHeights.html
Testing emHeights: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1643477 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Component: DOM: Core & HTML → Canvas: 2D

So there are a lot of tests tracked by this bug, so I think work should be done in dependent bugs. There are a few tests here that seem interesting:

  • html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.reload.html: This one interacts with image loading and thus doesn't seem super-easy.
  • html/canvas/element/text-styles/2d.text.font.parse.complex.html seems like a bug in the test that expects a particular serialization, so the test should be patched instead of Firefox changed.
  • html/canvas/element/pixel-manipulation/2d.imageData.create2.zero.html, this one seems trivial to fix, and is the first one I'd try.

Tests can be looked at in https://wpt.fyi/results/html/canvas/element/pixel-manipulation/2d.imageData.create2.zero.html, where there are links to run the test and so on. Interesting tests are the one that pass in at least one other browser and that we fail.

It seems like, for example, for the last one CanvasRenderingContext2D::CreateImageData should check for zero after clamping to int, rather than before.

I checked the tests on https://wpt.fyi
It seems that the following tests pass now:

  1. /html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.zerosource.html
  2. /html/canvas/element/drawing-text-to-the-canvas/2d.text.measure.advances.html

Rest are all still failing, I'm starting work on them

Depends on: 1684689
Depends on: 1685141
You need to log in before you can comment on or make changes to this bug.