Closed Bug 1643526 Opened 4 years ago Closed 4 years ago

Attachment comments don't render markdown, but their preview does

Categories

(bugzilla.mozilla.org :: Bug Creation/Editing, defect, P3)

Tracking

()

RESOLVED FIXED

People

(Reporter: bytesized, Assigned: dkl)

References

(Regression)

Details

Attachments

(1 file)

I just left a comment on a Bugzilla attachment, and it doesn't look right. It's using a monospace font and none of my markdown rendered. This seems unexpected to me, especially because in the original "Preview" tab, and in the "Edit Comment" "Preview" tab, it renders as I would expect.

I left the comment from this page: https://bugzilla.mozilla.org/attachment.cgi?id=9154380&action=edit

I took a look at Bug 1518967, since it seemed related. I then went back to the page where I left the comment, and saw that this element does seem to be on that page: <input type="hidden" name="markdown_off" value="1">.

But the original reason that was done does not apply to me. I didn't click the "Edit attachment as comment" button. So this feels like a bug. Even if we do, in fact, want this behavior, the preview should match what will actually be posted, rather than rendering markdown that won't actually be rendered.

Summary: Comment didn't render markdown → Attachment comments don't render markdown, but their preview does
Regressed by: 1518967

Oh, whoops. I was sure I had linked to the actual comment that had the issue, but it seems that I did not. Here it is: https://bugzilla.mozilla.org/show_bug.cgi?id=1612055#c13

I think I put this in the wrong component. Perhaps it fits better here?

Assignee: nobody → attach-and-request
Component: General → Attachments & Requests
Product: bugzilla.mozilla.org → Bugzilla
QA Contact: default-qa

I'm able to reproduce. Looks like a bug.

Moving to the right product/component and setting default assignee.

Assignee: attach-and-request → nobody
Severity: -- → S3
Component: Attachments & Requests → Bug Creation/Editing
Priority: -- → P3
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attached file GitHub Pull Request

This was merged and is live in production.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: