1518967 - Edit attachment as comment does markdown, which is very unexpected

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It doesn't say that it will, and it doesn't give you a way to preview.

As a result, you get things like the pre-edit version of https://bugzilla.mozilla.org/page.cgi?id=comment-revisions.html&bug_id=1513241&comment_id=13850021 which Bugzilla helpfully won't actually show you the way it was rendering the comment. But trust me, it was completely unreadable as a code review.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: Add escape hatch sequence for disabling markdown syntax, without using monospace fonts

Comment 2

[Dylan Hardison [:dylan] (he/him)]

This should be beneficial for some other use cases, like the problem reported in IRC by Wes.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Fwiw, or "edit attachment as comment" you do want a monospace font for all the quoted stuff, since it's code.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Sounds like that means wrapping in ``` then

Comment 5

[Boris Zbarsky [:bzbarsky]]

Which is a whole bunch of extra typing compared to the current workflow...

You also have to do the same for a bunch of the review comments, and if you forget you have no way to check whether you screwed up in the current setup where there is no preview.

I'm a little dubious of the value of proportional font for code review in general, since so much of it is code bits, but if we want it, we really need a preview here.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

I'm trying to fix this with the constraint that my team doesn't want to put any effort into any code review in bugzilla. I'll hash something out today with the BMO peers.

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Attachment: GitHub Pull Request