1643545 - Make sure the new WebRTC indicator is keyboard accessible

Status: VERIFIED FIXED

(Firefox :: Site Permissions, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

We need to make sure that users that don't use pointer input devices can use the indicator.

Comment 1

[James Teh [:Jamie]]

Possibilities:

1. Make it possible to alt+tab to the window. However, that requires it be a taskbar icon.
2. If we don't want alt+tab to get to it, my first thought is that ideally, f6 would focus it like it focuses all other notifications. Unfortunately, that's tricky (maybe impossible) because this is a global window. The problem is that if we use some other keyboard command, this isn't going to be discoverable.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Bug 1641546, when it lands, should make the indicator just like any other window, in that it will have a taskbar icon, and should be alt-tab'able. I think at that point, we just need to make sure that the tab order makes sense on the buttons in that window.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

With bug 1641546, it's possible to switch to the indicator using the keyboard, since it's behaving like any other window.

On macOS, it looks like we've inherited some code from the old indicator that intentionally hides the indicator from the Window list, and hides the window title. I think we can probably remove those now in this new version. That's what I'll use this bug for.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1643545 - Make sure WebRTC indicator appears in window list on macOS for keyboard accessibility. r?pbz!

Hiding the indicator in the window menu on macOS appears to be a holdover from the
legacy version of this indicator.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fab7c4f54054
Make sure WebRTC indicator appears in window list on macOS for keyboard accessibility. r=pbz

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fab7c4f54054

Comment 7

[Cristian Fogel [:cfogel]]

Verified with 79.0a1 (2020-06-11) on macOS 10.15.5