1643651 - Add actions to support DOH CFR

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Andrei Oprea [:andreio]]

Both button actions (primary and secondary) for DoH CFR modify preferences, we need to add new actions to support this.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1643651 - Add actions to support DOH CFR

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1643651 - Remove doorhanger-related code from doh-rollout extension and update tests. r=prathiksha!,andreio

Comment 3

[Phabricator Automation]

Comment on attachment 9157882 [details]
Bug 1643651 - Remove doorhanger-related code from doh-rollout extension and update tests. r=prathiksha!,andreio

Revision D80344 was moved to bug 1647215. Setting attachment 9157882 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89da43b8e31a
Add actions to support DOH CFR r=nhnt11,fluent-reviewers,flod

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 89da43b8e31a (Bug 1643651) for node-newtab-unit-tests failures.
https://hg.mozilla.org/integration/autoland/rev/9b38f4b9d883b2bc2c4f3d170942546c2d82aacf

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=89da43b8e31ac044c3adca6b453ff1cfe912ab38&selectedTaskRun=aLWBJx-JReycuMDYtU7_ig.0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307099239&repo=autoland&lineNumber=101

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/874e951d2674
Add actions to support DOH CFR r=nhnt11,fluent-reviewers,flod

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/874e951d2674

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the steps from here and I can confirm the following:
- The doh-rollout.doorhanger-decision pref is set to UIOk in the "about:config" page after the "OK, Got it" doorhanger's button is clicked.
- The doh-rollout.doorhanger-decision pref is set to UIDisabled in the "about:config" page after the "Disable" doorhanger's button is clicked.

Verified using the latest Firefox Nightly (79.0a1 Build ID - 20200629094229) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.