Closed
Bug 1648465
Opened 5 years ago
Closed 5 years ago
Make CFR doorhangers persistent through message configuration
Categories
(Firefox :: Messaging System, task, P2)
Tracking
()
VERIFIED
FIXED
Firefox 80
People
(Reporter: nhnt11, Assigned: andreio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
The popup should not be dismissed as soon as the user clicks anywhere, especially since there's no obvious way to intentionally get it back.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Summary: Make DoH CFR popup persistent → Make CFR doorhangers persistent through message configuration
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b897c0547d30
Make CFR doorhangers persistent through message configuration r=nhnt11
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
|
|
Assignee | |
Comment 5•5 years ago
|
||
Comment on attachment 9160662 [details]
Bug 1648465 - Make CFR doorhangers persistent through message configuration
Beta/Release Uplift Approval Request
- User impact if declined: User doorhanger notifications can be easily dismissed, user would miss the message we are sending.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Feature is remotely configured.
- String changes made/needed:
Attachment #9160662 -
Flags: approval-mozilla-beta?
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9160662 [details]
Bug 1648465 - Make CFR doorhangers persistent through message configuration
approved for 79.0b4
Attachment #9160662 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 7•5 years ago
|
||
| bugherder uplift | ||
status-firefox79:
--- → fixed
|
||
Comment 8•5 years ago
|
||
I have verified that the "DOH_ROLLOUT_CONFIRMATION" doorhanger is not dismissed by clicking inside the page, using the steps from here.
Verified using the latest Firefox Beta (79.0b5 Build ID - 20200708005253) and the latest Firefox Nightly (80.0a1 Build ID - 20200708214935) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.
You need to log in
before you can comment on or make changes to this bug.
Description
•