Closed Bug 1643887 Opened 4 years ago Closed 1 year ago

[One-off search] Unable to untick search engine with a comma

Categories

(Firefox :: Search, defect, P3)

79 Branch
defect

Tracking

()

RESOLVED FIXED
116 Branch
Tracking Status
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- wontfix
firefox116 --- fixed

People

(Reporter: mehose, Assigned: klubana)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.88 Safari/537.36

Steps to reproduce:

  1. Install "Add custom search engine" addon (https://addons.mozilla.org/en-US/firefox/addon/add-custom-search-engine/).
  2. Using the addon, add a new search engine and name it with a comma sign (","). The name can be anything, as long as it includes a comma.
  3. Untick that search engine in "One-Click Search Engines" of "about:preferences#search".
  4. Refresh "about:preferences#search".

Alternatively, a search engine (that has a comma in the name) also can be installed from mycroftproject.com; this is still supported in stable v77.

Actual results:

The search engine is still ticked.
The name can be "foo, bar" or even just a single comma ",", the result is still the same.

Expected results:

The search engine should remains unticked and hidden from the address bar.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Search

The severity field is not set for this bug.
:daleharvey, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dharvey)
Severity: -- → S3
Flags: needinfo?(dharvey)
Priority: -- → P3

Checked issue and is reproducible in all Os and all versions

Windows10 64bit, Ubuntu 18.04 64bit and macOs 10.15
Using firefox Release 77.0.1, Beta 78 and Nightly 79.0a1

Status: UNCONFIRMED → NEW
Ever confirmed: true

It has been this way for a long time - the preference that stores this is a comma-separated list of values (browser.search.hiddenOneOffs)

We should probably just move it into the cache and have it as a flag on the search engine object. It'd also make it better as then all the data would be stored together.

Blocks: 1757366
See Also: → 1689986
Depends on: 1689986
See Also: 1689986
Assignee: nobody → klubana
Status: NEW → ASSIGNED
Blocks: 1689986
No longer depends on: 1689986
Attachment #9337901 - Attachment description: Bug 1643887 - Untick search engine with a comma. r?Standard8 → Bug 1643887 - Move handling of search engine one-off hidden from preferences into the search settings. r?Standard8
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52f0232ceb58 Move handling of search engine one-off hidden from preferences into the search settings. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: