1689986 - One-off search engines removed via the tick are reactivated when changing browser-language

Status: VERIFIED FIXED

(Firefox :: Search, defect, P3)

Description

[Dan]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

1. Disable all search-engines (remove the blue ticks in this example screenshot https://i.postimg.cc/sgjXNJT7/search-Engines-Bug.jpg
2. Set browser-language from german to english or english to german
3. click "apply and restart"

Actual results:

search-engines are reactivated in that menu from that screenshot...

Expected results:

Changing the browser-language should definitely not mess with the user's search-engine customization.

Comment 1

[Dan]

Only appears to reset the entire search-engine customization if user did not tick any single search engine:
If user only leaves "Google" entry in that list (removes all others), and ticks that one blue, this bug appears to not occur.

Comment 2

[Mark Banner (:standard8)]

This only affects the one-click enable/disable, removing the engine in the UI works correctly.

Marking this as depending on bug 1650874 where we're working towards a rewrite of the search preferences UI, that may remove the separate option.

Comment 3

[Dan]

Thank you for adding the dependence bug 1650874 :)

Comment 4

[Mathew Hodson]

Is this the same as or related to bug 1628405?

Comment 5

[Mark Banner (:standard8)]

It is very loosely related, it is a different preference stored in a different place.

Comment 7

[Mark Banner (:standard8)]

It has been this way for a long time - the preference that stores this is a comma-separated list of values (browser.search.hiddenOneOffs).

We should migrate it into the search settings and have it as a flag on the search engine object. It'd also make it better as then all the data would be stored together.

Comment 9

[Mark Banner (:standard8)]

Bug 1643887 is currently fixing this.

Comment 10

[Mark Banner (:standard8)]

Fixed by bug 1643887

Comment 11

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-06-10 Nightly build on Windows 10.
Verified as fixed on Nightly 116.0a1(build ID: 20230620212415) on Windows 10, macOS 12, Ubuntu 22.
Changing the browser language does not re-check the previously unchecked search engines.