1644040 - ExtensionTestUtils's extension.unload() should await the completion of closing extension windows/tabs.

Status: NEW

(WebExtensions :: Android, task, P3)

Description

[Rob Wu [:robwu]]

Some extension tests rely on the moz-extension: window to be closed at the end of a test, and will otherwise trip the "Test left extra windows or tabs" message (well, if it were to be supported on GeckoView - bug 1565700).

Closing tabs is however asynchronous, so to avoid intermittent test failures, the async extension.unload() helper should make sure to await the tab close result:
https://searchfox.org/mozilla-central/rev/9ad88f80aeedcd3cd7d7f63be07f577861727054/mobile/android/components/extensions/ext-android.js#44-47

Otherwise there may be test failures like bug 1523398 (the recent errors are only on Fennec because GeckoView doesn't have the leaked window checker yet).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hey Rob, can this be changed from defect to task given that it is a test-only change? (and severity set to N/A)
Also could be demoted to P3? (given that this hasn't moved forward over the last 11 months)