1565700 - Enable check for "Test left extra windows or tabs:" in geckoview extension tests

Status: ASSIGNED

(WebExtensions :: Android, task, P3)

Description

[Rob Wu [:robwu]]

mochitests on Android perform a leaked window check, which is implemented here: https://searchfox.org/mozilla-central/rev/883bfd385efc917d5e787ba66fb51824f6f0e3d6/mobile/android/components/extensions/test/mochitest/head.js#33

It relies on chrome_cleanup_script.js, which currently enumerates navigator:browser. In GeckoView (non-Fennec), it should enumerate navigator:geckoview instead.

Comment 1

[Rob Wu [:robwu]]

Taking over this bug - once bug 1644039 and bug 1644040 have been fixed, then it should be possible to fix this bug, to prevent new instances of bug 1644039, because it is very difficult to debug this kind of issue. A way to investigate this kind of issue without the leaked window check is to look at logcat, and then check if the order of logged events match with what one would expect (when the content script appears to run sooner than a the creation of a new tab/window, then you can infer that the tab/window already existed at the start of the test). I confirmed a bunch of such errors in bug 1644039, but doing the analysis is too time-consuming and tedious.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Demoting to P3, but feel free to bump its priority again if it gets back into your queue of tasks to do next.