Closed Bug 1644075 Opened 5 years ago Closed 5 years ago

Error when opening a local html file in debugger

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox79 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: nchevobbe, Assigned: loganfsmyth)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1644075 - Make sure that injected scripts have no URL. r=jlast!
47 bytes, text/x-phabricator-request
Details | Review

If I have the following file stored locally (as error_highlight.html),

<html>
  <script>
    "ab".push("c");
  </script>
</html>

and try to open it in the debugger (file:///Users/nchevobbe/Desktop/error_highlight.html), I get:

Error: Incorrect contents fetched, please reload.

The severity field is not set for this bug.
:jlast, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jlaster)
Assignee: nobody → loganfsmyth
Status: NEW → ASSIGNED

I think there were still cases where this could happen before, but I made it worse with 1643540 accidentally.

Flags: needinfo?(jlaster)
Regressed by: 1643540
Has Regression Range: --- → yes

Yeah we also have https://bugzilla.mozilla.org/show_bug.cgi?id=1630791 so I have no idea which part used to break vs what broke with 1643540, either way this patch should be a good fix.

See Also: → 1643540
See Also: → 1630791
Pushed by loganfsmyth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0cb142657e59 Make sure that injected scripts have no URL. r=jlast

https://hg.mozilla.org/mozilla-central/rev/0cb142657e59

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
QA Whiteboard: [qa-79b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: