Distinguish BaselineInterpreter samples in Profiler
Categories
(Core :: Gecko Profiler, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(2 files)
When we added initial BaselineInterpreter support to Profiler in Bug 1551499, we emulated the samples generated by the C++ interpreter since the mechanism to build labels was closest to that. We would like to be able to distinguish the two implementations so this patch adds a flag in the profile buffer to sets the "implementation" field in JSON to "blinterp".
PR for the associated UI update: https://github.com/firefox-devtools/profiler/pull/2591
Assignee | ||
Comment 1•4 years ago
|
||
Round the number of reserved flag bits up to 16. This leaves 16-bits for the
category (so 64k subcategories). Also make the baseprofiler consistent.
Assignee | ||
Comment 2•4 years ago
|
||
Introduce an IS_BLINTERP_FRAME flag to ProfilingStackFrame to distinguish C++
and Baseline interpreter frames. In the profile data this sets the
"implementation" to "blinterp".
Depends on D78724
Comment 4•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/371d6825fc2e
https://hg.mozilla.org/mozilla-central/rev/a97bd52dc1e1
Description
•