1644218 - Distinguish BaselineInterpreter samples in Profiler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Ted Campbell [:tcampbell]]

When we added initial BaselineInterpreter support to Profiler in Bug 1551499, we emulated the samples generated by the C++ interpreter since the mechanism to build labels was closest to that. We would like to be able to distinguish the two implementations so this patch adds a flag in the profile buffer to sets the "implementation" field in JSON to "blinterp".

PR for the associated UI update: https://github.com/firefox-devtools/profiler/pull/2591

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1644218 - Cleanup ProfilingStackFrame flags

Round the number of reserved flag bits up to 16. This leaves 16-bits for the
category (so 64k subcategories). Also make the baseprofiler consistent.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1644218 - Add blinterp implementation tracking to profiler

Introduce an IS_BLINTERP_FRAME flag to ProfilingStackFrame to distinguish C++
and Baseline interpreter frames. In the profile data this sets the
"implementation" to "blinterp".

Depends on D78724

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/371d6825fc2e
Cleanup ProfilingStackFrame flags r=gerald
https://hg.mozilla.org/integration/autoland/rev/a97bd52dc1e1
Add blinterp implementation tracking to profiler r=jandem,gerald

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/371d6825fc2e
https://hg.mozilla.org/mozilla-central/rev/a97bd52dc1e1