Closed Bug 1644218 Opened 4 years ago Closed 4 years ago

Distinguish BaselineInterpreter samples in Profiler

Categories

(Core :: Gecko Profiler, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(2 files)

When we added initial BaselineInterpreter support to Profiler in Bug 1551499, we emulated the samples generated by the C++ interpreter since the mechanism to build labels was closest to that. We would like to be able to distinguish the two implementations so this patch adds a flag in the profile buffer to sets the "implementation" field in JSON to "blinterp".

PR for the associated UI update: https://github.com/firefox-devtools/profiler/pull/2591

Round the number of reserved flag bits up to 16. This leaves 16-bits for the
category (so 64k subcategories). Also make the baseprofiler consistent.

Introduce an IS_BLINTERP_FRAME flag to ProfilingStackFrame to distinguish C++
and Baseline interpreter frames. In the profile data this sets the
"implementation" to "blinterp".

Depends on D78724

Severity: -- → N/A
Priority: -- → P3
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/371d6825fc2e Cleanup ProfilingStackFrame flags r=gerald https://hg.mozilla.org/integration/autoland/rev/a97bd52dc1e1 Add blinterp implementation tracking to profiler r=jandem,gerald
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: