1644280 - Remove Fission pref check in nsXPLookAndFeel::GetColorImpl for modal highlighter

Status: NEW

(Core :: Find Backend, task, P3)

Description

[u608768]

This came up in D78799#inline-453521:

Can you file a follow-up bug about this use, and ni the person to added it? I don't understand why we'd need to check this pref here.

for the StaticPrefs::fission_autostart() check in nsXPLookAndFeel::GetColorImpl: https://searchfox.org/mozilla-central/rev/35b97af64a55d1d30caa4d6e9fabc1a7fbabc509/widget/nsXPLookAndFeel.cpp#874

Comment 1

[u608768]

Neil, this was added in bug 1553384.

Comment 2

[Neil Deakin]

The modal highlighter preference is currently ignored for fission as it otherwise doesn't render correctly (the highlight is invisible) and won't draw across iframes. Now that we enable out-of-process iframes per window that code could be changed to not use the preference.

Comment 3

[Chris Peterson [:cpeterson]]

Neil, what work is needed to make the modal highlighter compatible with Fission? Is the modal highlighter preffed off by default? Does fixing this bug need to block shipping Fission?

(In reply to :kashav from comment #0)

for the StaticPrefs::fission_autostart() check in nsXPLookAndFeel::GetColorImpl: https://searchfox.org/mozilla-central/rev/35b97af64a55d1d30caa4d6e9fabc1a7fbabc509/widget/nsXPLookAndFeel.cpp#874

btw, the StaticPrefs::fission_autostart() pref check described in comment 0 has since been replaced by a mozilla::FissionAutostart() pref check:

https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/widget/nsXPLookAndFeel.cpp#878

Comment 4

[Neil Deakin]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1597500#c7

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Neil Deakin from comment #4)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1597500#c7

Thanks! Mike said in that bug:

There's absolutely no need to have this [modal highlighter] block the Fission project.

As such, I will move this bug to the Fission Future milestone (alongside bug 1597500).