1644297 - Dark Reader no longer working / fails to initialize

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect, P1)

Description

[Christian Sadilek [:csadilek]]

Dark Reader stopped working in Nightly 79.0.20200605043926.

Still fine in Nightly 79.0.20200604092907.

Fenix bug: https://github.com/mozilla-mobile/fenix/issues/11336

Relevant entry from the logs:

can't access property "config", $sync is undefined index.js:1896
    loadSettingsFromStorage moz-extension://f330e768-8120-488d-b54e-28e2209d7a63/background/index.js:1896
    apply self-hosted:1941
    applySafeWithoutClone resource://gre/modules/ExtensionCommon.jsm:614
    wrapPromise resource://gre/modules/ExtensionCommon.jsm:843
    withLastError resource://gre/modules/ExtensionCommon.jsm:762
    wrapPromise resource://gre/modules/ExtensionCommon.jsm:831
    loadExtensionFile moz-extension://6b69d78a-1335-42dd-b4fd-9f39115ab558/background-scripts/util.js:49
    applyStoredRulesets moz-extension://6b69d78a-1335-42dd-b4fd-9f39115ab558/background-scripts/update.js:218
    InterpretGeneratorResume self-hosted:1151
    AsyncFunctionNext self-hosted:693
Unchecked lastError value: Error: An unexpected error occurred index.js:1894
    loadSettingsFromStorage moz-extension://f330e768-8120-488d-b54e-28e2209d7a63/background/index.js:1894

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Thanks. Bisecting...

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

14:44.57 INFO: Last good revision: 6bb6a5cdc941eaa15c0e36dcaf8e4ad8509d4e90
14:44.57 INFO: First bad revision: fc977a4eff9e6a1d27b1efdc3e0980bc5958976d
14:44.57 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6bb6a5cdc941eaa15c0e36dcaf8e4ad8509d4e90&tochange=fc977a4eff9e6a1d27b1efdc3e0980bc5958976d

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Mark any ideas? this seems to completely break storage.sync on Android.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1644297 - Re enable old browser.storage.sync on Android.

This also adds a smoke test which runs on all platforms to avoid regressions.

Comment 5

[Lina Butler (ex-Mozilla)]

Ooof, thanks for catching this, Agi!

Wait, though—how did this sync before, given that we aren't shipping the Desktop FxA stack in GV? Or was Dark Reader effectively using storage.sync for local storage only before?

I wrote about one way we could support storage.sync in GV, so that Android Components could wire it up to our Rust component, in this comment—do you think that would work?

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

No worries! Yeah storage.sync is effectively a local storage today on Android.

Yeah I just linked that comment on our bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1625257 the API you describe is very similar to what snorp and I were thinking last time we talked about this, it should work!

Comment 7

[Lina Butler (ex-Mozilla)]

Gotcha! I'll follow bug 1625257; thanks for linking to it, and for the fix and test!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02e2cc3bd511
Re enable old browser.storage.sync on Android. r=rpl,snorp

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/02e2cc3bd511

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9155440 [details]
Bug 1644297 - Re enable old browser.storage.sync on Android.

I'm going to graft this to beta along with bug 1645598. The pref change is a no-op there, but this way 78 will get the new test file (which is modified in that other bug).

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dce83a6b19e2