1644366 - TextArea in a container does not scroll to the selection

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P2)

Description

[elena.guenther]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36

Steps to reproduce:

The issue occurs with the Update to FireFox 77.0.1 (64-Bit)

Steps to reproduce the problem:

Use the url to codepen to verify it: https://codepen.io/eguenther/pen/oVGrzW

First Case:
TextArea is in a container.

1. Click on the button scroll to selection (Scrolling to selection does not work!) in the linked codepen.

Second Case:
TextArea is stand alone.

1. Click on the button scroll to selection (Scrolling to selection work!)

Actual results:

Actual Results:

The first Case:
The Text is selected but there is no scrolling to the selection.

The second Case:
The Text is selected und the textarea scrolls to the selection.

Expected results:

Expected Results:

Scrolling to the selection should work in both cases.

It works as expected in Chrome, Safari, Edge Chromium

Notes: I found a bug fix for: https://bugzilla.mozilla.org/show_bug.cgi?id=1634153
This Bug was fixed a month ago. May be it is a reason for this issue?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Notes: I found a bug fix for: https://bugzilla.mozilla.org/show_bug.cgi?id=1634153

Yeah, confirmed that via mozregression. Thanks for filing.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1634153

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1644366 - Restore behavior of selection into view to keep scrolling ancestors on focus. r=smaug

... yet keep respecting the preventScroll flag.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1884e1c2ccf4
Restore behavior of selection into view to keep scrolling ancestors on focus. r=smaug

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24064 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for scrolling failures.

backout: https://hg.mozilla.org/integration/autoland/rev/0df8de966ed2e4b88e81d560322891399873576b

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1884e1c2ccf4ee8a19f800ae738785b481f751de&test_paths=layout%2Fforms%2Ftest%2Ftest_bug564115.html&selectedTaskRun=X1jai3coTByoBDNflKor3g-0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305671462&repo=autoland&lineNumber=14424

[task 2020-06-09T18:01:17.256Z] 18:01:17 INFO - TEST-START | layout/forms/test/test_bug564115.html
[task 2020-06-09T18:01:17.318Z] 18:01:17 INFO - GECKO(1663) | [Parent 1663, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp, line 4275
[task 2020-06-09T18:01:17.963Z] 18:01:17 INFO - TEST-INFO | started process screencapture
[task 2020-06-09T18:01:18.131Z] 18:01:18 INFO - TEST-INFO | screencapture: exit 0
[task 2020-06-09T18:01:18.131Z] 18:01:18 INFO - Buffered messages logged at 18:01:17
[task 2020-06-09T18:01:18.131Z] 18:01:18 INFO - must wait for load
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - must wait for focus
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - Buffered messages finished
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug564115.html | Page should be scrolled correctly - got 12, expected 5000
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:383:14
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - @layout/forms/test/test_bug564115.html:33:11
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - setTimeout handlerSimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:788:41
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - @layout/forms/test/test_bug564115.html:32:17
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - setTimeout handlerSimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:788:41
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - @layout/forms/test/test_bug564115.html:28:15
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - focusedOrLoaded/<@SimpleTest/SimpleTest.js:918:23
[task 2020-06-09T18:01:18.132Z] 18:01:18 INFO - must wait for focus
[task 2020-06-09T18:01:18.133Z] 18:01:18 INFO - must wait for focus
[task 2020-06-09T18:01:18.133Z] 18:01:18 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-06-09T18:01:18.133Z] 18:01:18 INFO - TEST-UNEXPECTED-FAIL | layout/forms/test/test_bug564115.html | The page's scroll offset should not have been changed - got 12, expected 5000

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90d8f871d49d
Restore behavior of selection into view to keep scrolling ancestors on focus. r=smaug

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/90d8f871d49d

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot