1644487 - browser.menus.onClicked - tab is not defined in callback when click occurs on a message out of the messageWindow

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Emmanuel SELLIER]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36

Steps to reproduce:

1/ create a context menu, with permissions including "menus"
2/ listen for clicks
3/ run and open a message in a new window
4/ right-click inside the message

Actual results:

The click handler is called with first argument for Info, but the second argument (tab) is undefined.
The click on the same menu (and same handler) will receive both arguments : info and tab.

Expected results:

The click handler should receive both arguments : info and tab
tab is useful if you need to have the tab.id and open the messageDisplayAction (for instance) popup for the specific tab.id

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1644487-message-window-menu-1.diff

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/18ac9cf0ff4b
Fix tab argument of menu API when in a message display window. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9158080 [details] [diff] [review]
1644487-message-window-menu-1.diff

Just a WebExtensions edge case, not a risk.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9158080 [details] [diff] [review]
1644487-message-window-menu-1.diff

Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 78.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/15c8fba4b027