1644544 - Include experimental features in crash stats

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Similar to bug 1644542, Experimental Features that are enabled should be listed in crash stats.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

It's not clear to me if we need to annotate crash stats on every startup or if the values can be persisted across executions, thus only needing to annotate crash stats when preference values change. @Gabriele, is it enough to just annotate crash stats when the preference value changes?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1644544 - Annotate crash-stats reports with the enabled experimental features.

Comment 3

[Gabriele Svelto [:gsvelto]]

Crash annotations are not persisted across executions, you need to set them every time.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Data review form

Comment 5

[Chris H-C :chutten]

Comment on attachment 9158932 [details]
Data review form

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is a Crash Annotation so can be controlled through Firefox's Preferences about crash reports as well as the Data Collection preference.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :jaws is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28d0dc323af8
Annotate crash-stats reports with the enabled experimental features. r=gsvelto,Gijs,preferences-reviewers,mstriemer

Comment 7

[Dorel Luca [:dluca]]

Backed out 4 changesets (bug 1646423, bug 1644544, bug 1646178, bug 1648223) for browser-chrome failures in browser/components/preferences/tests/browser_basic_rebuild_fonts_test.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307622245&repo=autoland&lineNumber=2449

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=XP3mAIjbQc-hfP18OIoBHQ.0&revision=48790fe7990a69934299ad1f7618c3093ace2176

Backout:
https://hg.mozilla.org/integration/autoland/rev/9b981fcfb6ac3119837605e3189c5832446c77ab

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f914931d3709
Annotate crash-stats reports with the enabled experimental features. r=gsvelto,Gijs,preferences-reviewers,mstriemer

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f914931d3709