1724596 - 'ExperimentalFeatures' annotation in crash report lists all available Nightly Experiments, supposed to only list enabled ones

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

From https://searchfox.org/mozilla-central/rev/f1c881ba5603410dacbe52874053af38bd825c3b/toolkit/components/telemetry/docs/data/crash-ping.rst#65

ExperimentalFeatures: <features>, // Optional, a comma-separated string that specifies the enabled experimental features from about:preferences#experimental

Crash reports list all available features under Experimental Features, see e.g. bp-dbc120ec-1482-49de-af7d-a4d100210807 > Crash Annotations tab > Protected data > ExperimentalFeatures and compare with Firefox > Settings > Nightly Experiments (best to do with one of your own crash reports).

The reason is the filter Array method is synchronous and the promises are true-ish.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1724596 - 'ExperimentalFeatures' annotation in crash report should only list enabled ones. r=jaws

Array's filter method is synchronous which caused its arrow function to
always return true-ish Promises instead of a Boolean value.

No other filter(async can be found in the code base.

Comment 2

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/05453b34b831

Comment 3

[Julien Cristau [:jcristau] (back April 22)]

Is this worth uplifting?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

No uplfit needed, hasn't caused issues before.