1644662 - autocomplete element access with autoclose bracket enabled insert extra closing quote and bracket

Status: VERIFIED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the console
2. Type document["a
3. The input should be document["a|"] because autoclose bracket is enabled
4. Hit Enter to accept the completion of activeElement

Expected results

The input is now document["activeElement"]

Actual results

The input is now document["activeElement"]"] (note the extra closing quote and bracket)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1644662 - Fix accepting element access autocompletion with autoclose bracket enabled. r=bomsy.

When the autoclose bracket addon is enabled, quotes and ] are automatically
inserted, but that wasn't taken into account in the function that is in charge
of setting the input value when the user accept the autocompletion.
This patch should fix this, and add a few tests to makes sure we don't regress.

Depends on D78935

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50d4094fc4e1
Fix accepting element access autocompletion with autoclose bracket enabled. r=bomsy.

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/50d4094fc4e1

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9155650 [details]
Bug 1644662 - Fix accepting element access autocompletion with autoclose bracket enabled. r=bomsy.

Beta/Release Uplift Approval Request

• User impact if declined: Incorrect input in the console when using the autocompletion with brackets
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See steps from Comment 0
• List of other uplifts needed: Bug 1644158
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): DevTools only, covered by automated test
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau] (back August 18)]

I'm a bit confused since you set status-firefox78 to wontfix and then requested uplift; which is it? :)

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

ugh sorry, that's what happen when you try to do many things at the same time.

Comment 8

[Peter Magyari (Desktop QA)]

Reproduced the issue on Nightly 79.0a1 (20200610214041)
Verified fixed on Nightly 79.0a1 (20200616215006)

Comment 9

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9155650 [details]
Bug 1644662 - Fix accepting element access autocompletion with autoclose bracket enabled. r=bomsy.

approved for 78.0b9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/38b5b535b997

Comment 11

[Peter Magyari (Desktop QA)]

Verified fixed on Beta 78.0b9 (20200619002543) and 78.0esr (20200623021425)