1644680 - foreignObject overflow:visible not working

Status: NEW

(Core :: SVG, defect)

Description

[breakthroughTGW]

Attachment: test2.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.97 Safari/537.36

Steps to reproduce:

set foreignObject overflow property to visible
insert elements into foreignObject after timeout 1000ms

Actual results:

elements not visible

Expected results:

elements should visible

Comment 1

[Alice0775 White]

regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=976d771a3b16d637d077d4fa9c272d2370e76510&tochange=133a13c44abedac2e448d315a32068ce1a5568f4

Comment 2

[Jonathan Kew [:jfkthame]]

Not a particularly recent regression (2 years), but this definitely looks broken.

Triggering a reflow (e.g. by zooming, or modifying a property like font-size on the foreignObject) causes the missing content to pop into view.

Markus, given the range in comment 1, it looks like your patches may be responsible for this. Can you take a look?

Comment 3

[Markus Stange [:mstange]]

Hmm, the patch at https://hg.mozilla.org/mozilla-central/rev/09b3d826af11 makes me think that, since this worked before bug 1458968, it was probably working by accident.
And since bug 1557245, it "should" be working.

I suppose there's a missing reflow here that would be needed to update the visual overflow rect?
I don't know the SVG reflow code, I'm not the right person to fix this bug.

Maybe Violet is interested in giving this a spin?

Comment 5

[jbovey]

I'm hoping this comment will revive this bug to get resolved.

1.) Go to https://whiteboard.onlinelearningsessions.com/ff_text_testing.
2.) Select the "T" tool (text), then click on the board and start typing. Note that after a few characters, the text is not rendering. A similar thing tends to happen when hitting enter to add text on the next line.
3.) Hit f12 to inspect element.
4.) Change something like font-size or color or font-family, etc. and notice that the previously typed text shows up.

Please advise if anything else is needed in order to correct this, as this bug is impacting the usage of the app that my customers use.

Comment 6

[ulima.ums]

Looking at the reproduction case it seems like the first child of the foreignObject is always fully visible. More specifically the first block line is always visible (which most of the cases means that the first child of the first child of the first child is visible) and all the elements on different lines are not. Can we narrow it down through that?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.

Comment 8

[jbovey]

This but is still present. Please advise on when it will be fixed.

Comment 9

[Jonathan Watt [:jwatt]]

Right now there are no plans to work on this particular bug. foreignObject is low priority.

Comment 10

[jbovey]

Is there a suggested workaround in the meantime, at least? This is screwing up a custom build we are using for FF users.

Comment 11

[Robert Longson [:longsonr]]

Increase the height or width of the foreignObject element so its contents don't overflow.

Comment 12

[jbovey]

Yeah, that's not an option.

Again, steps to reproduce...
1.) Go to https://whiteboard.onlinelearningsessions.com/ff_text_testing.
2.) Select the "T" tool (text), then click on the board and start typing. Note that after a few characters, the text is not rendering. A similar thing tends to happen when hitting enter to add text on the next line.
3.) Click outside the textbox editor and notice that the previously typed text shows up.