1644772 - Browser Toolbox failed to open with a service worker exception

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

While trying to debug bug 1611945, I got the Browser Toolbox to fail opening.
And saw such error via the Browser Console:

Error while calling actor 'serviceWorkerRegistration's method 'allowShutdown' Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIServiceWorkerInfo.detachDebugger] Actor.js:91:13
allowShutdown@resource://devtools/server/actors/worker/service-worker-registration.js:273:39
handler@resource://devtools/shared/protocol/Actor.js:162:37
onPacket@resource://devtools/server/devtools-server-connection.js:380:58
_onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:464:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22

It may be one of the reason why it breaks, outside of the pending update issue.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1644772 - Avoid an exception when we fail detaching a SW on destroy.

No idea if that is the real reason why the Browser Toolbox failed opening.
It isn't clear how WorkerTarget detach is implying in toolbox opening?

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1644772 - Avoid an exception when we fail detaching a SW on destroy.

No idea if that is the real reason why the Browser Toolbox failed opening.
It isn't clear how WorkerTarget detach is implying in toolbox opening?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/826c7b86e19c
Avoid an exception when we fail detaching a SW on destroy. r=jdescottes

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/826c7b86e19c