1644975 - icons in bookmarks panel are stretched

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: screen shot

See the attached screen shot: the icons next to bookmark entries in the bookmarks panel are stretched. mozregression points me to bug 1574746. Sotaro, can you take a look?

Comment 1

[Cameron McCormack (:heycam)]

(The stretched icons are the bookmarks star and the history clock.)

Comment 2

[Sotaro Ikeda [:sotaro]]

:heycam, thank for the report. Can you upload about:support to this bug? Does the problem happen on another PCs?

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1574746

Comment 4

[Cameron McCormack (:heycam)]

Attachment: my about:support

Comment 5

[Cameron McCormack (:heycam)]

For my other machines:

• macOS with WebRender force enabled - not stretched
• Linux with WebRender force enabled - stretched
• Windows with WebRender enabled by default - not stretched

Comment 6

[Sotaro Ikeda [:sotaro]]

I take a look.

Comment 7

[Sotaro Ikeda [:sotaro]]

The stretched pat was svg.
https://searchfox.org/mozilla-central/rev/2c1092dc68c63f7bad6da6a03c5883a5ab5ff2ca/browser/themes/shared/customizableui/panelUI.inc.css#1159
https://searchfox.org/mozilla-central/rev/2c1092dc68c63f7bad6da6a03c5883a5ab5ff2ca/browser/themes/shared/customizableui/panelUI.inc.css#1155

Their sizes seem to be set in the following.
https://searchfox.org/mozilla-central/rev/2c1092dc68c63f7bad6da6a03c5883a5ab5ff2ca/browser/themes/shared/customizableui/panelUI.inc.css#1163

Comment 8

[Sotaro Ikeda [:sotaro]]

From the symptom, it seems that Y was not scaled from 16px to 12px.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - -moz-context-properties: none

Comment 10

[Sotaro Ikeda [:sotaro]]

As Attachment 9157277 [details] [diff], when -moz-context-properties was none an WebRender was disabled, the cons were rendered as stretched like with WebRender.

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1644975 - Change scaleX to scale

Comment 12

[Sotaro Ikeda [:sotaro]]

With Attachment 9157280 [details], the problem was addressed with WebRender for me. I am not sure why scaleX is used there.

When -moz-context-properties is valid, svg image was always rendered by keeping aspect ratio.

Comment 13

[Sotaro Ikeda [:sotaro]]

When -moz-context-properties was valid and WebRender was disabled, scaleX() did not stretch svg image in one direction. Its aspect ratio
was kept. I am not sure if it is a correct behavior.

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: temporal patch - Do not create SVGImageContex in SVGImageContext::MaybeStoreContextPaint()

Comment 15

[Sotaro Ikeda [:sotaro]]

With Attachment 9157284 [details] [diff], SVGImageContex is not created in SVGImageContext::MaybeStoreContextPaint(). With it, svg image became stretched even with valid -moz-context-properties.

Comment 16

[Sotaro Ikeda [:sotaro]]

The following explains about -moz-context-properties.
https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-context-properties

Comment 17

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #13)

When -moz-context-properties was valid and WebRender was disabled, scaleX() did not stretch svg image in one direction. Its aspect ratio
was kept. I am not sure if it is an expected behavior.

:jrmuizel, do you know if it is an expected behavior?

Comment 18

[Sotaro Ikeda [:sotaro]]

Created Bug 1646618 for the scaleX() problem with -moz-context-properties and without WebRender.

Comment 19

[Sotaro Ikeda [:sotaro]]

:mikedeboer, do you know why scaleX() is used instead of scale() there?

Comment 20

[Jeff Muizelaar [:jrmuizel]]

I don't think -moz-context-properties should affect what happens with scaleX(). It seems like bug 1646618 is the true problem here.

Comment 21

[Julien Cristau [:jcristau] (back August 18)]

Calling this disabled for 78 since it sounds like this was only seen on linux?

Comment 22

[Sotaro Ikeda [:sotaro]]

(In reply to Julien Cristau [:jcristau] from comment #21)

Calling this disabled for 78 since it sounds like this was only seen on linux?

Yes, it affects only to linux with WebRender.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/929046a4e267
Change scaleX to scale r=jrmuizel,dao

Comment 24

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/929046a4e267