1574746 - Search suggestions not drawn in WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[mesvam]

Attachment: screenshot.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Steps to reproduce:

Reproduce:

1. Type text in search bar
2. Deselect/unfocus search bar (e.g. by clicking outside)
3. Focus the search bar again

Actual results:

The drop down of suggestions is partially drawn. Showing only drop shadows on the border, but the content is not visible.

Comment 1

[mesvam]

Attachment: about:support

Comment 2

[Darkspirit]

bug 1551598 only fixed bug 1462173. This is the same issue.

Comment 3

[Sotaro Ikeda [:sotaro]]

mesvam, does the problem still happens with latest nightly?

Comment 4

[mesvam]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)

mesvam, does the problem still happens with latest nightly?

Yup, still there

Comment 5

[Sotaro Ikeda [:sotaro]]

Thanks for checking! Since OS is Widows 7, Bug 1573710 is not related to this bug.

Comment 6

[Sotaro Ikeda [:sotaro]]

Some invalidation bugs were addressed by Bug 1595014 and Bug 1624216.

Comment 7

[Sotaro Ikeda [:sotaro]]

I confirmed that the problem still happen on latest nightly on Windows 7.

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #7)

I confirmed that the problem still happen on latest nightly on Windows 7.

But search suggestion did not use WebRender. But I did not see the problem when WebRender was disabled :(

Comment 9

[Sotaro Ikeda [:sotaro]]

When D3D11 Advanced Layers was enabled on Win7, the problem did not happen. But in this case, pop up was hardware accelerated. With WebRender, the popup was not accelerated(BasicCompositor).

When I modified the code as that pop up always uses BasicCompositor, D3D11 Advanced Layers usage also caused the problem.

Comment 10

[Sotaro Ikeda [:sotaro]]

nsBaseWidget::AllowWebRenderForThisWindow() limit WebRender usage to some windows. It was added by Bug 1377321, because initialization of WebRender was heavy weight in the past. See Bug 1377321 Comment 3. The initialization problem does not exist anymore on WebRender on Windows.

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1574746 - Remove AllowWebRenderForThisWindow()

Comment 12

[Darkspirit]

The time when bug 1377321 merged I saw a notable delay when opening uBlock Origin on my KDE/X11/Debian Testing/Radeon RX480 desktop.
Today, the delay is almost not noticeable on my KDE/X11/Debian Testing/Intel Iris 6100 (Broadwell GT3) laptop, but compared to the main menu it's still possible to close a panel before it has shown, by double clicking on its button. Using WR for main menu and context menu should still be fine.

Comment 15

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a16df35d2f9e9902ec9f484a15f9a3637f7a2b4d

Comment 16

[Sotaro Ikeda [:sotaro]]

Conformed that Attachment 9141460 [details] addressed the problem on my Win7 PC.

Comment 17

[Darkspirit]

(In reply to Sotaro Ikeda [:sotaro] from comment #15)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a16df35d2f9e9902ec9f484a15f9a3637f7a2b4d

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #12)

but compared to the main menu it's still possible to close a panel before it has shown, by double clicking on its button.

That seems only to apply to (even lightweight) webextensions.
Non-webextension panels like the main menu use WebRender in this try build, but are still shown as fast as Basic.

With gfx.webrender.debug.primitives I noticed that Basic is still used for the context menu.

Comment 18

[Sotaro Ikeda [:sotaro]]

That seems only to apply to (even lightweight) webextensions.
Non-webextension panels like the main menu use WebRender in this try build, but are still shown as fast as Basic.

With gfx.webrender.debug.primitives I noticed that Basic is still used for the context menu.

The patch does not expected to use WebRender for all windows(widgets). When ComputeShouldAccelerate()/WidgetTypeSupportsAcceleration() return false, widget does not use WebRender.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/339795d0a51e
Remove AllowWebRenderForThisWindow() r=nical

Comment 20

[Andrei Ciure[:aciure]]

Backed out changeset 339795d0a51e (bug 1574746) for causing browser_startup_syncIPC.js failures
https://hg.mozilla.org/integration/autoland/rev/0affade618e1c7b0343356c61d37057868c6bd30

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cshippable%2Copt%2Cmochitests%2Ctest-windows10-64-shippable-qr%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&revision=339795d0a51eb84d7d792e1b610c068f52f99b7a&selectedJob=298538484

log: https://treeherder.mozilla.org/logviewer.html#?job_id=298538484&repo=autoland

also introduced this: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C7%2Cshippable%2Copt%2Ctest-windows7-32-shippable%2Fopt-marionette-e10s%2C%28mn%29&fromchange=339795d0a51eb84d7d792e1b610c068f52f99b7a&tochange=0affade618e1c7b0343356c61d37057868c6bd30

log: https://treeherder.mozilla.org/logviewer.html#?job_id=298536613&repo=autoland

Comment 22

[Sotaro Ikeda [:sotaro]]

(In reply to Andrei Ciure[:aciure] from comment #20)

also introduced this: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C7%2Cshippable%2Copt%2Ctest-windows7-32-shippable%2Fopt-marionette-e10s%2C%28mn%29&fromchange=339795d0a51eb84d7d792e1b610c068f52f99b7a&tochange=0affade618e1c7b0343356c61d37057868c6bd30

log: https://treeherder.mozilla.org/logviewer.html#?job_id=298536613&repo=autoland

It seems already exist as Bug 1631112 . This should not related to this bug. The failure happen on Windows 7 Shippable opt. But the patch affect only to WebRender. Windows 7 Shippable opt does not use WebRender.

Comment 23

[Sotaro Ikeda [:sotaro]]

(In reply to Andrei Ciure[:aciure] from comment #20)

Backed out changeset 339795d0a51e (bug 1574746) for causing browser_startup_syncIPC.js failures
https://hg.mozilla.org/integration/autoland/rev/0affade618e1c7b0343356c61d37057868c6bd30

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cshippable%2Copt%2Cmochitests%2Ctest-windows10-64-shippable-qr%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&revision=339795d0a51eb84d7d792e1b610c068f52f99b7a&selectedJob=298538484

The above failure was addressed.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff965eed4ddc138ce28ba25836f112503b4c2146

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/786823305560
Remove AllowWebRenderForThisWindow() r=nical

Comment 25

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/786823305560

Comment 26

[Dorel Luca [:dluca]]

Backed out changeset 786823305560 (bug 1574746) for Browser-chrome failures in test/performance/browser_startup_syncIPC.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300804500&repo=autoland&lineNumber=2746

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=786823305560b03316cb758207f76838388603af

Backout:
https://hg.mozilla.org/integration/autoland/rev/786823305560b03316cb758207f76838388603af

Comment 27

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/559943097aee
Backed out changeset 786823305560 for Browser-chrome failures in test/performance/browser_startup_syncIPC.js. CLOSED TREE

Comment 28

[Darkspirit]

(In reply to Andrei Ciure[:aciure] from comment #20)

log: https://treeherder.mozilla.org/logviewer.html#?job_id=298538484&repo=autoland

Build: - windows10-64-shippable-qr -

[task 2020-04-21T00:36:46.463Z] 00:36:46 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_syncIPC.js | unexpected PWebRenderBridge::Msg_EnsureConnected sync IPC before handling user events -

(In reply to Dorel Luca [:dluca] from comment #26)

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300804500&repo=autoland&lineNumber=2746

Build: - windows10-64-shippable-qr -

[task 2020-05-05T02:54:24.427Z] 02:54:24 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_syncIPC.js | unused whitelist entry before handling user events: PWebRenderBridge::Msg_EnsureConnected -

It wants an ignoreIfUnused: true,

[task 2020-05-05T02:54:24.429Z] 02:54:24 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_syncIPC.js | unexpected PWebRenderBridge::Msg_EnsureConnected sync IPC before becoming idle -

It wants another entry at "before becoming idle", probably also with ignoreIfUnused: true,.

Comment 29

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/559943097aee

Comment 30

[Sotaro Ikeda [:sotaro]]

Updated patch addressed test failures.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d346ce90256d705c640c0d96f57f2f4b1f0ac8b

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a43f9853075
Remove AllowWebRenderForThisWindow() r=nical

Comment 32

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/6a43f9853075

Comment 33

[Florin Strugariu [:Bebe]]

== Change summary for alert #25845 (as of Wed, 06 May 2020 12:46:59 GMT) ==

Improvements:

3% raptor-tp6-docs-firefox-cold fcp windows10-64-shippable-qr opt 1,013.29 -> 983.17

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25845