1645169 - Polish the CardDAV dialog

Status: RESOLVED FIXED

(Thunderbird :: Address Book, task)

Description

[Richard Marti (:Paenglab)]

The actual CardDAV dialog should get some polishing.
The first row isn't aligned with the other rows. On Windows, the select element's height is a lot smaller than the input fields. There is too much white space.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1645169-improve-CardDAV-dialog.patch

Like this.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9156043 [details] [diff] [review]
1645169-improve-CardDAV-dialog.patch

Review of attachment 9156043 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Please, update the commit message with "Bug 1645169 - Improve the UI of the CardDAV dialog. r=aleca" since we're only touching the UI here and not improving anything else.

Could this be a candidate for uplifting to beta? Since CardDav is on 78, even if experimental, and the changes are minimal.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1645169-improve-CardDAV-dialog.patch

Updated the commit message.

[Approval Request Comment]
Regression caused by (bug #): 546932
User impact if declined: not well aligned dialog
Testing completed (on c-c, etc.): in c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/647d32570b5c
Improve the CardDAV dialog. r=aleca

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9156171 [details] [diff] [review]
1645169-improve-CardDAV-dialog.patch

Approved for beta

Comment 6

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/f39af6ece3c8