1645466 - The new WebRTC indicator is resizable on Linux

Status: VERIFIED FIXED

(Firefox :: Site Permissions, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

It shouldn't be resizable. Not sure if this should actually be under Widget::Gtk.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey mstransky. The WebRTC indicator is not supposed to be resizable. The Picture-in-Picture window is (it has a "resizable" feature set on it), but the resizable feature isn't set on the WebRTC indicator.

What's the right place to hook into gtk/nsWindow.cpp to express that this window should not be resizable?

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO, back on Jul 7)]

I see Windows already use that:

https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/widget/windows/nsWindow.cpp#357

co we can copy the logic somehow to Gtk. I'll look at it.

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Jul 7)]

Mike, may we set size constrains to the indicator window? We should sey both min/max size to the same values. I don't know how to disable the resize on gtk level without regression.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Yep, I think we can do that on the front-end. Thanks for looking into this!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1645466 - Prevent the WebRTC indicator from being resized manually on Linux GTK. r?pbz

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21f12164b249
Prevent the WebRTC indicator from being resized manually on Linux GTK. r=pbz

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/21f12164b249

Comment 8

[Negritas Sergiu, Desktop QA]

Hello! I have managed to reproduce the issue on Linux 18.04 LTS with Firefox Nightly 79.0a1 (2020-06-10). I can confirm that the issue is fixed on Fx Nightly 79.0a1 (2020-06-17), Firefox 79.0 and on Fx Nightly 81.0a1 (2020-08-14).