1645512 - Crash in [@ nsAbLDAPProcessReplicationData::Done]

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

I've labeled this as version 78, but it goes back at least as far as 75. Some other recent crashes
bp-83c745b3-a0e8-42b5-a93e-9d51c0200609 2020-06-09 02:35:35 Thunderbird 79.0a1
bp-1ac46faf-c002-4516-addb-212e20200603 2020-06-03 19:02:31 Thunderbird 77.0

So far, a low rate crash of 1-2 crashes per week for beta.

Perhaps a duplicate?

This bug is for crash report bp-d9c11996-056a-494a-b7ba-337c50200605.

Top 10 frames of crashing thread:

0 xul.dll nsAbLDAPProcessReplicationData::Done comm/mailnews/addrbook/src/nsAbLDAPReplicationData.cpp:367
1 xul.dll nsAbLDAPListenerBase::OnLDAPInit comm/mailnews/addrbook/src/nsAbLDAPListenerBase.cpp:65
2 xul.dll nsLDAPConnection::OnLookupComplete comm/ldap/xpcom/src/nsLDAPConnection.cpp:582
3 xul.dll mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/netwerk/dns/DNSListenerProxy.cpp:28:30'>::Run xpcom/threads/nsThreadUtils.h:574
4 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1211
5 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:501
6 xul.dll mozilla::AppWindow::ShowModal xpfe/appshell/AppWindow.cpp:505
7 xul.dll nsWindowWatcher::OpenWindowInternal toolkit/components/windowwatcher/nsWindowWatcher.cpp:1309
8 xul.dll nsWindowWatcher::OpenWindow2 toolkit/components/windowwatcher/nsWindowWatcher.cpp:375
9 xul.dll nsGlobalWindowOuter::OpenInternal dom/base/nsGlobalWindowOuter.cpp:7075

Comment 1

[Ben Campbell]

Attachment: 1645512-pre-bind-error-fix-1.patch

Looks like the cleanup code doesn't handle the case where a failure occurs before the LDAP bind completes.
I've picked my way through the cleanup code and this patch should make it tolerant of that incomplete state, but I've not replicated the bug to actually test it out. (in fact, from a user-facing point of view I couldn't even tell you what action this code is performing ;- )

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9157503 [details] [diff] [review]
1645512-pre-bind-error-fix-1.patch

Review of attachment 9157503 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a55755a0f3fe
Make nsAbLDAPProcessReplicationData handle failures which occur before LDAP bind completes. r=mkmelin DONTBUILD

Comment 4

[Wayne Mery (:wsmwk)]

According to crash-stats, this is gone from beta.
Let's take this for next esr.

Comment 5

[Ben Campbell]

Sounds promising. The patch plugs up a definite issue, so if that was the sole cause of this bug, I'm happy :-)

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9157503 [details] [diff] [review]
1645512-pre-bind-error-fix-1.patch

[Approval Request Comment]
Crash fix

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9157503 [details] [diff] [review]
1645512-pre-bind-error-fix-1.patch

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/586a1c982f0b