1645560 - Hit MOZ_CRASH(explicit panic) at gfx/wr/webrender/src/render_task.rs:37

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Hit MOZ_CRASH(explicit panic) at gfx/wr/webrender/src/render_task.rs:37

39|0|libxul.so|RustMozCrash|hg:hg.mozilla.org/mozilla-central:mozglue/static/rust/wrappers.cpp:b2df79a80c0303df9d710800ae37dce56847eef5|17|0x15
39|1|libxul.so|mozglue_static::panic_hook|hg:hg.mozilla.org/mozilla-central:mozglue/static/rust/lib.rs:b2df79a80c0303df9d710800ae37dce56847eef5|89|0x9
39|2|libxul.so|core::ops::function::Fn::call|git:github.com/rust-lang/rust:src/libcore/ops/function.rs:4fb7144ed159f94491249e86d5bbd033b5d60550|72|0xc
39|3|libxul.so|std::panicking::rust_panic_with_hook|git:github.com/rust-lang/rust:src/libstd/panicking.rs:4fb7144ed159f94491249e86d5bbd033b5d60550|474|0x7
39|4|libxul.so|std::panicking::begin_panic|git:github.com/rust-lang/rust:src/libstd/panicking.rs:4fb7144ed159f94491249e86d5bbd033b5d60550|397|0x27
39|5|libxul.so|webrender::render_task::RenderTask::new_mask|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/render_task.rs:b2df79a80c0303df9d710800ae37dce56847eef5|0|0x98
39|6|libxul.so|webrender::prim_store::BrushSegment::update_clip_task|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|1042|0x21
39|7|libxul.so|webrender::prim_store::PrimitiveStore::prepare_prim_for_render|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|4191|0x3f
39|8|libxul.so|webrender::prim_store::PrimitiveStore::prepare_primitives|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2831|0x2a
39|9|libxul.so|webrender::prim_store::PrimitiveStore::prepare_prim_for_render|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2712|0x2d
39|10|libxul.so|webrender::prim_store::PrimitiveStore::prepare_primitives|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2831|0x2a
39|11|libxul.so|webrender::prim_store::PrimitiveStore::prepare_prim_for_render|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2712|0x2d
39|12|libxul.so|webrender::prim_store::PrimitiveStore::prepare_primitives|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2831|0x2a
39|13|libxul.so|webrender::prim_store::PrimitiveStore::prepare_prim_for_render|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2712|0x2d
39|14|libxul.so|webrender::prim_store::PrimitiveStore::prepare_primitives|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2831|0x2a
39|15|libxul.so|webrender::prim_store::PrimitiveStore::prepare_prim_for_render|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2712|0x2d
39|16|libxul.so|webrender::prim_store::PrimitiveStore::prepare_primitives|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2831|0x2a
39|17|libxul.so|webrender::prim_store::PrimitiveStore::prepare_prim_for_render|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2712|0x2d
39|18|libxul.so|webrender::prim_store::PrimitiveStore::prepare_primitives|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2831|0x2a
39|19|libxul.so|webrender::prim_store::PrimitiveStore::prepare_prim_for_render|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2712|0x2d
39|20|libxul.so|webrender::prim_store::PrimitiveStore::prepare_primitives|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/prim_store/mod.rs:b2df79a80c0303df9d710800ae37dce56847eef5|2831|0x2a
39|21|libxul.so|webrender::frame_builder::FrameBuilder::build|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/frame_builder.rs:b2df79a80c0303df9d710800ae37dce56847eef5|475|0x3c
39|22|libxul.so|webrender::render_backend::Document::build_frame|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/render_backend.rs:b2df79a80c0303df9d710800ae37dce56847eef5|615|0x22
39|23|libxul.so|webrender::render_backend::RenderBackend::update_document|hg:hg.mozilla.org/mozilla-central:gfx/wr/webrender/src/render_backend.rs:b2df79a80c0303df9d710800ae37dce56847eef5|1520|0x1c

Comment 1

[Connor Brewster [:cbrewster]]

Looks like this is caused by a similar issue as Bug 1645281. We need to be limiting the size of box shadow render tasks.

Comment 2

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/JUmnWgB67494mWVcKrqpDA/index.html

Comment 3

[Darkspirit]

bp-9e1fc773-af8e-4286-a48d-956a50200613

GraphicsCriticalError |[G0][GFX1-]: Attempting to create a render task of size 51840000x39936000 (t=10675.6)

mozregression --good 2020-05-10 --bad 2020-06-12 --pref gfx.webrender.all:true -a about:support -a https://bugzilla.mozilla.org/attachment.cgi?id=9156473

7:47.17 INFO: Last good revision: 6e5ab322dc4d0a68833dbd73e55a4657d0c219c2
7:47.17 INFO: First bad revision: a94271c84318acba14a63c52ba98afe512b071f7
7:47.17 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6e5ab322dc4d0a68833dbd73e55a4657d0c219c2&tochange=a94271c84318acba14a63c52ba98afe512b071f7

a94271c84318acba14a63c52ba98afe512b071f7 cbrewster — Bug 1559861: WR - Scale picture tasks based on their surface to parent transform scale factors r=gw,Bert

Comment 4

[Connor Brewster [:cbrewster]]

This was resolved by the same fix for bug 1645281

https://hg.mozilla.org/mozilla-central/rev/b51500258c3a