Closed Bug 1645700 Opened 4 years ago Closed 4 years ago

Fat focus ring around search boxes

Categories

(Thunderbird :: Theme, task)

Product:
Thunderbird
Component:
Theme
Type:
task

Tracking

(thunderbird78 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 79.0
Tracking Flags:
Tracking Status
thunderbird78 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

1645700-no-outline-searchBox.patch
2.08 KB, patch
aleca
: review+
wsmwk
: approval-comm-beta+
Details | Diff | Splinter Review

Especially on Mac when a search box has the focus, the focusring is really fat.

This is since bug 1311444.

We have to set outline: none; like in bug 1311444 or other m-c bugs.

[Approval Request Comment]
Regression caused by (bug #): bug 1311444
User impact if declined: especially on Mac very fat focusring on searchboxes
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9156584 - Flags: review?(alessandro)
Attachment #9156584 - Flags: approval-comm-beta?
Comment on attachment 9156584 [details] [diff] [review]
1645700-no-outline-searchBox.patch

Approved for beta
Attachment #9156584 - Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 9156584 [details] [diff] [review]
1645700-no-outline-searchBox.patch

Review of attachment 9156584 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #9156584 - Flags: review?(alessandro) → review+
Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 79.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/e73144b8bc4a
Disable some undesired outlines for the searchBox class. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: