1645724 - Crash in [@ IconWindowProc] related to Windows minimize to tray

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

So far, crashes are all Windows. This crash report is the first, version 76, bp-68c58b95-2cd6-4eff-ac31-aa1620200421.

history: https://crash-stats.mozilla.org/signature/?product=Thunderbird&signature=IconWindowProc&date=%3E%3D2019-12-14T22%3A10%3A00.000Z&date=%3C2020-06-14T22%3A10%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#reports

Top 10 frames of crashing thread:

0 xul.dll IconWindowProc comm/mailnews/base/src/nsMessengerWinIntegration.cpp:1094
1 user32.dll _InternalCallWinProc 
2 user32.dll long __stdcall UserCallWinProcCheckWow 
3 user32.dll DispatchClientMessage 
4 user32.dll __fnDWORD 
5 ntdll.dll KiUserCallbackDispatcher 
6 ntdll.dll KiUserApcDispatcher 
7 user32.dll PeekMessageW 
8 msctf.dll virtual long __stdcall CThreadInputMgr::PeekMessageW 
9 xul.dll nsAppShell::ProcessNextNativeEvent widget/windows/nsAppShell.cpp:504

Comment 1

[Wayne Mery (:wsmwk)]

and another signature
InvalidArrayIndex_CRASH | IconWindowProc bp-899a097b-3f4d-47da-841d-4b54a0200615

Comment 2

[Magnus Melin [:mkmelin]]

The one from comment 0 looks to be at https://searchfox.org/comm-central/rev/361d3ff8a878f3ea9d7dbac0f1dce07dffc7d0ed/mailnews/base/src/nsMessengerWinIntegration.cpp#1081 (null widget)

From minimize to tray.

Comment 3

[Wayne Mery (:wsmwk)]

a selection that does not have minimize
bp-8e56e81c-2ea3-4add-bfca-7aa060200911
bp-09603e48-954c-45e6-b89a-e37490200911
bp-afeb8255-a269-4ac3-b8d2-419fd0200911

slightly different signature InvalidArrayIndex_CRASH | IconWindowProc bp-6482edca-54d6-441f-aa66-da9750200911

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1645724_minimize_crash.patch

Could help.

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9175482 [details] [diff] [review]
bug1645724_minimize_crash.patch

Makes sense.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5cbb805362a9
fix Crash in [@ IconWindowProc]. r=darktrojan

Comment 7

[Wayne Mery (:wsmwk)]

I think this could be taken in the next esr, unless you want to see it on beta more than a week.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9175482 [details] [diff] [review]
bug1645724_minimize_crash.patch

[Approval Request Comment]
Yeah, safe crash fix.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9175482 [details] [diff] [review]
bug1645724_minimize_crash.patch

[Triage Comment]
approved for esr78 - limited risk

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.3.0:
https://hg.mozilla.org/releases/comm-esr78/rev/a09dab26b533