1645862 - Don't load most of TelemetryController.jsm in content processes

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task)

Description

[Kris Maglione [:kmag]]

It occupies a huge amount of memory in each content process, and most of it is never actually used.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Do you have an estimate of how much memory it is using in total?

Comment 2

[Kris Maglione [:kmag]]

At least 30K

Comment 3

[Jan-Erik Rediger [:janerik]]

Last time we tackled that we got some reductions of Telemtry in content processes, but the effort died out a bit, including refactoring TelemetryController itself (bug 1479719).
If we need to re-prioritize this then we need some new planning inside the team I guess.

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1645862: Part 1 - Move submitExternalPing out of TelemetryController. r=chutten

This is the only part of TelemetryController used by external code in the
content process, so separating it from the rest of TelemetryController is the
first step to completely segregating parent- and content-specific code.

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1645862: Part 1 - Split TelemetryController into parent and content modules. r=chutten

Most of TelemetryController is only used in the parent process, but is
currently loaded in all processes, where it needlessly consumes tens of KB of
memory. This patch splits the parent- and content-specific parts, and only
loads each in the processes where they're needed.

Comment 6

[Kris Maglione [:kmag]]

Attachment: Bug 1645862: Part 2 - Get rid of ContentProcessSingleton. r=chutten

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12e1039aba47
Part 1 - Split TelemetryController into parent and content modules. r=chutten
https://hg.mozilla.org/integration/autoland/rev/015c7a1af896
Part 2 - Get rid of ContentProcessSingleton. r=chutten

Comment 8

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1645862) for XPCShell on telemetry/tests/unit/test_TelemetrySend.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307309064&repo=autoland&lineNumber=3338

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307308805&repo=autoland&lineNumber=6577

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=015c7a1af896e2e2b6f3aa78312dd5c3aa19fbdf

Backout:
https://hg.mozilla.org/integration/autoland/rev/a1d7cda1bac6b575c91cce9593b47ebe434bc261

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4643e4db774
Part 1 - Split TelemetryController into parent and content modules. r=chutten
https://hg.mozilla.org/integration/autoland/rev/c5ae0087c1e7
Part 2 - Get rid of ContentProcessSingleton. r=chutten

Comment 10

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1645862) for browser-chrome failures in performance/browser_startup_content.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307330664&repo=autoland&lineNumber=2947

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=IpFzu1k4QbesDickV377Zw.0&revision=c5ae0087c1e7c2ef728076cc647a878e0850782e

Backout:
https://hg.mozilla.org/integration/autoland/rev/54338e4097360805ea890258016104d8b144fdf6

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4bca734f663
Part 1 - Split TelemetryController into parent and content modules. r=chutten
https://hg.mozilla.org/integration/autoland/rev/003cd7d6b5de
Part 2 - Get rid of ContentProcessSingleton. r=chutten

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f4bca734f663
https://hg.mozilla.org/mozilla-central/rev/003cd7d6b5de

Comment 13

[Florin Strugariu [:Bebe]]

== Change summary for alert #26325 (as of Thu, 25 Jun 2020 04:59:47 GMT) ==

Improvements:

7% Base Content Resident Unique Memory windows10-64-shippable-qr opt 13,904,981.33 -> 12,923,562.67
4% Base Content JS windows10-64-shippable opt 3,748,973.33 -> 3,597,664.67
4% Base Content JS windows10-64-shippable-qr opt 3,748,800.00 -> 3,599,192.67
4% Base Content JS windows7-32-shippable opt 2,866,150.50 -> 2,764,338.67
3% Base Content JS linux1804-64-shippable opt 3,665,037.00 -> 3,539,590.67
3% Base Content JS linux1804-64-shippable-qr opt 3,665,020.67 -> 3,539,534.00
3% Base Content JS macosx1014-64-shippable opt 3,682,026.33 -> 3,558,734.33

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26325