1648854 - Telemetry Logging has stopped working

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Chris H-C :chutten]

Telemetry Logging can be turned on by setting toolkit.telemetry.log.level to a log level (e.g. Trace). You can get it to pipe to console by setting toolkit.telemetry.log.dump to the boolean true.

This isn't working with latest mozilla-central, but reverting the two patches from bug 1645862 (and the one from bug 1648178 first so it doesn't complain about merge conflicts) makes it work again.

My only guess is the logger is configured someplace in TelemetryController and I missed that it was no longer called in the review.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1648854: Fix telemetry logging. r=dexter

Setting the log level on a logger with a prefix doesn't work, because the
property isn't a setter, and prefix loggers use Object.create to create a new
object with the real logger as their prototype.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbca5bc5254b
Fix telemetry logging. r=Dexter

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cbca5bc5254b

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1645862

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kmag, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Kris Maglione [:kmag]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #5)

The patch landed in nightly and beta is affected.

I don't know. I think that's for someone who works on Telemetry to decide. Normal users won't notice that at all. It only matters for debugging.

Comment 7

[Chris H-C :chutten]

I think we should uplift as any run-on-beta testsfails would miss crucial information.

Comment 8

[Chris H-C :chutten]

Comment on attachment 9159857 [details]
Bug 1648854: Fix telemetry logging. r=dexter

Beta/Release Uplift Approval Request

• User impact if declined: None to end users. Devs might have a harder time dealing with test failures with a lack of logs.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The risk is low because this is a change to logging in the Telemetry component which is off by default (on by default in tests)
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9159857 [details]
Bug 1648854: Fix telemetry logging. r=dexter

Approved for 79.0b6.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/26369dacb8c0