Context menus, date pickers and datalists for extension popup windows and action panels
Categories
(Thunderbird :: Add-Ons: Extensions API, enhancement)
Tracking
(thunderbird78 fixed)
| Tracking | Status | |
|---|---|---|
| thunderbird78 | --- | fixed |
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(4 files)
|
26.67 KB,
patch
|
mkmelin
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
|
2.57 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
|
6.82 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
|
14.26 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
This bug is about ensuring the appropriate UI bits are in place for pages that a WebExtension might show in a <browser>. There are several places this could happen:
- browser action, compose action and message display action pop-up arrow panels
- content tabs
- the message pane of the 3-pane tab (not really for extensions but we still show web pages there)
- the new lightweight pop-up window
Some of these places already use the mailContext context menu, which also contains items for handing messages. Those aren't wanted at all in some windows, but I don't want to duplicate the code, so I'll use the preprocessor to filter the items.
|
Assignee | |
Comment 1•4 years ago
|
||
This prepares the mail context menu for the possibility that it is outside messenger.xhtml, and includes it and the date/time picker in extensionPopup.xhtml.
I'm not sure if the list of protocols (imap, mailbox, news and snews in setMessageTargets) covers everything. Have I forgotten any?
|
|
Assignee | |
Comment 2•4 years ago
|
||
This fixes the context menu and date/time picker in browser action panels.
|
|
Assignee | |
Comment 3•4 years ago
|
||
This adds the context menu, date/time pickers and datalist to compose actions.
|
|
Assignee | |
Comment 4•4 years ago
|
||
Test for context menu in all of the above places, plus message display action panels which didn't need any more changes.
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Comment 5•4 years ago
|
||
Comment on attachment 9156928 [details] [diff] [review] 1645945-pt4-test-1.diff Review of attachment 9156928 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/base/test/browser/files/sampleContent.html @@ +1,4 @@ > +<!DOCTYPE html> > +<html> > + <head> > + <meta charset="utf-8"/> nit: in html there should be a space before close, <meta charset="utf-8" /> @@ +7,5 @@ > + <body> > + <p>This is a page of sample content for tests.</p> > + <p><a href="https://www.thunderbird.net/">Link to a web page</a></p> > + <form> > + <input type="text"/> here too
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c5c8c85775ff
Add the mailContext menu to extension popup windows. r=mkmelin
https://hg.mozilla.org/comm-central/rev/de2afb9327c6
Fix the context menu and date picker for browserAction panels. r=mkmelin
https://hg.mozilla.org/comm-central/rev/0a28c75b5de9
Add context menu and other popups to composeAction panel. r=mkmelin
https://hg.mozilla.org/comm-central/rev/387694d31eb3
Test that the mailContext menu shows appropriate items. r=mkmelin
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 7•4 years ago
|
||
Comment on attachment 9156924 [details] [diff] [review] 1645945-pt1-standalone-window-1.diff Asking for approval for all four parts, but without the bugspam :-) [Approval Request Comment] Regression caused by (bug #): User impact if declined: things won't work as expected for extension content in many situations Testing completed (on c-c, etc.): Risk to taking this patch (and alternatives if risky): some risk, but failure would be noticed quickly, and there's good test coverage of the menu which is the risky bit
|
||
Comment 8•4 years ago
|
||
Comment on attachment 9156924 [details] [diff] [review] 1645945-pt1-standalone-window-1.diff Approved for beta
|
||
Comment 9•4 years ago
|
||
| bugherder uplift | ||
|
|
||
Updated•4 years ago
|
Description
•