1646098 - Implement aspect-ratio for grid

Status: RESOLVED WORKSFORME

(Core :: Layout: Grid, enhancement, P2)

Description

[Boris Chiou [:boris]]

Implement aspect-ratio for display: grid.

Comment 1

[Boris Chiou [:boris]]

Basically, we support aspect-ratio on Grid layout already, but I'm still checking some special cases, like Automatic minimum size of grid items with aspect-ratio. We don't have wpt for gris layout for aspect-ratio now, so I will add some in this bug.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1646098 - Add basic wpts for aspect-ratio on grid layout.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1646098 - Fix Automatic Minimum Size of Grid Items for aspect-ratio property.

Comment 4

[Boris Chiou [:boris]]

Need to check this issue:
https://codepen.io/jensimmons/pen/JjRZVwg?editors=1100

Comment 5

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #4)

Need to check this issue:
https://codepen.io/jensimmons/pen/JjRZVwg?editors=1100

Looks like we only apply aspect-ratio on those grid items (nsBlockFrame), but not on nsGridContainerFrame, so the grid layout looks weird in this case.

Comment 6

[Boris Chiou [:boris]]

Need to update:
https://software.hixie.ch/utilities/js/live-dom-viewer/saved/8914

grid item: <div style="height: 100px; justify-self: stretch; aspect-ratio: 1/1; background: green;"></div>
we should update to stretch, instead of using ar.

Comment 7

[Boris Chiou [:boris]]

Grid item sizing shares the same code with basic blocks, so no need to do a special handle for it.

Comment 8

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #7)

Grid item sizing shares the same code with basic blocks, so no need to do a special handle for it.

And we don't have to handle for transferred size suggestion for non-replaced elements now.