Implement aspect-ratio for grid
Categories
(Core :: Layout: Grid, enhancement, P2)
Tracking
()
People
(Reporter: boris, Assigned: boris)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-needed)
Attachments
(2 obsolete files)
Implement aspect-ratio for display: grid.
Assignee | ||
Comment 1•4 years ago
|
||
Basically, we support aspect-ratio
on Grid layout already, but I'm still checking some special cases, like Automatic minimum size of grid items with aspect-ratio
. We don't have wpt for gris layout for aspect-ratio
now, so I will add some in this bug.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Need to check this issue:
https://codepen.io/jensimmons/pen/JjRZVwg?editors=1100
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
(In reply to Boris Chiou [:boris] from comment #4)
Need to check this issue:
https://codepen.io/jensimmons/pen/JjRZVwg?editors=1100
Looks like we only apply aspect-ratio on those grid items (nsBlockFrame), but not on nsGridContainerFrame, so the grid layout looks weird in this case.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Need to update:
https://software.hixie.ch/utilities/js/live-dom-viewer/saved/8914
grid item: <div style="height: 100px; justify-self: stretch; aspect-ratio: 1/1; background: green;"></div>
we should update to stretch, instead of using ar.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
Grid item sizing shares the same code with basic blocks, so no need to do a special handle for it.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 8•4 years ago
•
|
||
(In reply to Boris Chiou [:boris] from comment #7)
Grid item sizing shares the same code with basic blocks, so no need to do a special handle for it.
And we don't have to handle for transferred size suggestion for non-replaced elements now.
Assignee | ||
Updated•4 years ago
|
Description
•