Please create "preferences-reviewers" group and a matching Herald rule
Categories
(Conduit :: Phabricator, task)
Tracking
(Not tracked)
People
(Reporter: jaws, Assigned: dkl)
References
Details
+++ This bug was initially created as a clone of Bug #1619279 +++
For changes to code in the Firefox Preferences, which are their own submodule, please create a preferences-reviewers group containing:
- Jared Wein, https://phabricator.services.mozilla.com/p/jaws/
- Mark Striemer, https://phabricator.services.mozilla.com/p/mstriemer/
- Tim Nguyen, https://phabricator.services.mozilla.com/p/ntim/
Please also create a Herald rule to add the group as a blocking reviewer for files inside any of the following paths:
browser/components/preferences
Thank you. :)
|
||
Comment 1•5 years ago
|
||
I don’t know if an automatic Herald rule is a good idea, I was thinking of using the group more like how #style is currently used. Meaning only used for changes which no specific reviewer is more “suited” (e.g. one-line changes), especially for a diverse component like preferences. The style system component currently works this way which is quite nice.
Also, would it be possible to add #prefs or #preferences as shortcut ? (Not sure which one is preferred)
|
Assignee | |
Comment 2•5 years ago
|
||
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #1)
I don’t know if an automatic Herald rule is a good idea, I was thinking of using the group more like how #style is currently used. Meaning only used for changes which no specific reviewer is more “suited” (e.g. one-line changes), especially for a diverse component like preferences. The style system component currently works this way which is quite nice.
Let me know if you want to go a different route on this request, otherwise I can go ahead and create the project and the herald rule.
Also, would it be possible to add #prefs or #preferences as shortcut ? (Not sure which one is preferred)
A project can have additional hash tags assigned to it as shortcuts.
|
Reporter | |
Comment 3•5 years ago
|
||
My worry is that people submitting patches won't know about the hash tags and will continue to just request review from myself or other browser peers.
|
|
||
Updated•5 years ago
|
|
|
Reporter | |
Comment 4•5 years ago
|
||
After talking more with Tim and Mark, we've decided to move forward with this request. We would like the group to be added as blocking reviewers. This will be helpful for other teams that are making changes to the preferences, so we can make sure shared components such as the built-in Search feature continue to work as well as styling changes are consistent with the rest of the preferences.
|
|
Assignee | |
Comment 5•5 years ago
•
|
||
Done
https://phabricator.services.mozilla.com/project/view/132/
https://phabricator.services.mozilla.com/H252/
|
|
Reporter | |
Comment 6•5 years ago
|
||
Hey David, the group got created as "preference-reviewers". Do you think you could change it to "preferences-reviewers"? The difference is subtle but I think it has a slightly different connotation. Thanks!
|
|
Assignee | |
Comment 7•5 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
Hey David, the group got created as "preference-reviewers". Do you think you could change it to "preferences-reviewers"? The difference is subtle but I think it has a slightly different connotation. Thanks!
Sorry. typo. Fixed now.
|
|
Reporter | |
Comment 8•5 years ago
|
||
Thank you for the prompt fix as well as the original changes!
Description
•