Closed
Bug 1647867
Opened 5 years ago
Closed 5 years ago
Update preferences-reviewers herald rule
Categories
(Conduit :: Phabricator, defect)
Conduit
Phabricator
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ntim, Assigned: dkl)
References
Details
Sorry for missing this earlier, but after discussion w/ :jaws, we have decided to add:
- browser/themes/*/preferences
- toolkit/mozapps/preferences
to the Herald rule.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → dkl
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•5 years ago
|
||
(In reply to Tim Nguyen :ntim (please use needinfo?) from comment #0)
Sorry for missing this earlier, but after discussion w/ :jaws, we have decided to add:
- browser/themes/*/preferences
- toolkit/mozapps/preferences
to the Herald rule.
I might have to make more than one rule as the regex for the three different paths will get pretty complicated. Herald does not allow for OR conditions inside of an AND grouping unfortunately. Will just take a bit more time but won't hurt anything.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•